[PM-10394] Add new item type ssh key #4575

quexten · 2024-08-01T15:35:14Z

🎟️ Tracking

Server: #4575
Add Item Type: bitwarden/clients#10360
Add SSH Agent: bitwarden/clients#10293
Add Import/Export: bitwarden/clients#10529

Jira: https://bitwarden.atlassian.net/browse/PM-10395

📔 Objective

Add server support for the new ssh key cipher type. This is mostly copy paste from the other cipher types, with the one exception that we are filtering out ssh keys for older clients, using SSHKeyCipherMinimumVersion. We will update this once we know which release ssh keys will be in.

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov · 2024-08-01T15:44:57Z

Codecov Report

Attention: Patch coverage is 30.61224% with 34 lines in your changes missing coverage. Please review.

Project coverage is 41.89%. Comparing base (2d762f8) to head (39ab9a7).
Report is 64 commits behind head on main.

Files	Patch %	Lines
src/Api/Vault/Models/Request/CipherRequestModel.cs	6.25%	15 Missing ⚠️
src/Api/Vault/Models/CipherSSHKeyModel.cs	40.00%	6 Missing ⚠️
...c/Api/Vault/Models/Response/CipherResponseModel.cs	0.00%	6 Missing ⚠️
src/Core/Vault/Models/Data/CipherSSHKeyData.cs	0.00%	4 Missing ⚠️
src/Api/Vault/Controllers/SyncController.cs	76.92%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4575      +/-   ##
==========================================
+ Coverage   41.64%   41.89%   +0.24%     
==========================================
  Files        1271     1290      +19     
  Lines       60187    60961     +774     
  Branches     5527     5599      +72     
==========================================
+ Hits        25066    25540     +474     
- Misses      33951    34231     +280     
- Partials     1170     1190      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-01T16:07:38Z

Checkmarx One – Scan Summary & Details – 2d0264ec-67cb-49f5-8760-c66c22e0da7c

New Issues

Issue	Source File / Package	Checkmarx Insight
CSRF	/src/Api/Public/Controllers/CollectionsController.cs: 87	Attack Vector
CSRF	/src/Api/Controllers/CollectionsController.cs: 171	Attack Vector
CSRF	/src/Api/Controllers/CollectionsController.cs: 143	Attack Vector
CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 316	Attack Vector
CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 316	Attack Vector
CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 316	Attack Vector
CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 316	Attack Vector
CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 316	Attack Vector
Privacy_Violation	/src/Core/Auth/Services/Implementations/AuthRequestService.cs: 147	Attack Vector
Privacy_Violation	/src/Core/Services/Implementations/UserService.cs: 840	Attack Vector
Log_Forging	/src/Api/Billing/Controllers/ProviderClientsController.cs: 29	Attack Vector
Open_Redirect	/src/Admin/Auth/Controllers/LoginController.cs: 50	Attack Vector
Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/Welcome.html.hbs: 63	Attack Vector
Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/Welcome.html.hbs: 63	Attack Vector
Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/Welcome.html.hbs: 63	Attack Vector
Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/Welcome.html.hbs: 63	Attack Vector
Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/Welcome.html.hbs: 50	Attack Vector
Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/Welcome.html.hbs: 43	Attack Vector
Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/Welcome.html.hbs: 30	Attack Vector
Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/Welcome.html.hbs: 23	Attack Vector
Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/Welcome.html.hbs: 23	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Passwords And Secrets - Generic Password	/test-database.yml: 92
	Passwords And Secrets - Generic Password	/test-database.yml: 170
	Passwords And Secrets - Generic Password	/test-database.yml: 111
	Passwords And Secrets - Generic Password	/test-database.yml: 105
	Passwords And Secrets - Generic Password	/test-database.yml: 80
	Passwords And Secrets - Generic Password	/test-database.yml: 177
	Passwords And Secrets - Generic Password	/test-database.yml: 69
	Passwords And Secrets - Generic Password	/test-database.yml: 173
	CSRF	/src/Api/Controllers/CollectionsController.cs: 143
	CSRF	/src/Api/Controllers/CollectionsController.cs: 171
	CSRF	/src/Api/Public/Controllers/CollectionsController.cs: 87
	CSRF	/src/Api/Vault/Controllers/SyncController.cs: 59
	CSRF	/src/Api/SecretsManager/Controllers/CountsController.cs: 37
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 118
	CSRF	/src/Api/Controllers/CollectionsController.cs: 171
	CSRF	/src/Api/Controllers/CollectionsController.cs: 143
	CSRF	/src/Api/Public/Controllers/CollectionsController.cs: 87
	CSRF	/src/Api/SecretsManager/Controllers/CountsController.cs: 37
	CSRF	/src/Api/Vault/Controllers/SyncController.cs: 59
	Privacy_Violation	/src/Api/Vault/Models/Request/CipherRequestModel.cs: 198
	Privacy_Violation	/src/Core/Services/Implementations/UserService.cs: 851
	Privacy_Violation	/src/Core/Auth/Services/Implementations/AuthRequestService.cs: 160
	Privacy_Violation	/src/Api/Vault/Models/Request/CipherRequestModel.cs: 198
	Unpinned Actions Full Length Commit SHA	/build.yml: 515
	Unpinned Actions Full Length Commit SHA	/build.yml: 598
	Unpinned Actions Full Length Commit SHA	/build.yml: 548
	Heap_Inspection	/src/Api/Vault/Models/Request/CipherRequestModel.cs: 165
	Heap_Inspection	/src/Api/Vault/Models/Request/CipherRequestModel.cs: 165
	Log_Forging	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 118
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 151
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 118
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 151
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 118
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 151
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 151
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 118
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 118
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 151
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 151
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 118
	Log_Forging	/src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
	Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/Billing/TrialInitiationVerifyEmail.html.hbs: 17
	Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/Billing/TrialInitiationVerifyEmail.html.hbs: 17

rawkode · 2024-08-10T08:21:24Z

Very excited by this! Preparing to ditch 1Password as I type 🙂

quexten · 2024-08-16T12:24:14Z

Setting this to ready for review, but it will not be merged until all ssh of the ssh key features are ready.

Add ssh key item type

0093725

quexten added the hold Hold this PR or item until later; DO NOT MERGE label Aug 1, 2024

quexten changed the title ~~[PM-10394] Add ssh key item type~~ [PM-10394] Add new item type ssh key Aug 1, 2024

Add fingerprint

cd5baf4

This was referenced Aug 2, 2024

Add support for ssh-key item-type quexten/goldwarden#272

Open

[PM-10395] Add new item type ssh key bitwarden/clients#10360

Merged

[PM-10098] SSH Agent & SSH Key creation for Bitwarden Desktop bitwarden/clients#10293

Merged

quexten added 2 commits August 8, 2024 15:14

Limit ssh key ciphers to new clients

ddec883

Fix enc string length for 4096 bit rsa keys

c755ec3

quexten mentioned this pull request Aug 13, 2024

Windows & Mac Support quexten/goldwarden#4

Open

25 tasks

Remove keyAlgorithm from ssh cipher

39ab9a7

quexten marked this pull request as ready for review August 16, 2024 12:25

quexten requested a review from a team as a code owner August 16, 2024 12:25

quexten requested a review from gbubemismith August 16, 2024 12:25

quexten removed the hold Hold this PR or item until later; DO NOT MERGE label Aug 21, 2024

Add featureflag and exclude mobile from sync

f582cf5

gbubemismith approved these changes Aug 29, 2024

View reviewed changes

quexten mentioned this pull request Oct 1, 2024

PM-10393 SSH keys bitwarden/clients#10825

Open

lizard-boy mentioned this pull request Oct 19, 2024

[PM-10394] Add new item type ssh key grepdemos/server#52

Open

quexten mentioned this pull request Oct 21, 2024

SSH keys manager AChep/keyguard-app#640

Open

fedemkr mentioned this pull request Oct 30, 2024

[PM-10401] Implemented SSH Key type handling bitwarden/ios#1092

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-10394] Add new item type ssh key #4575

[PM-10394] Add new item type ssh key #4575

quexten commented Aug 1, 2024 •

edited

Loading

codecov bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

rawkode commented Aug 10, 2024

quexten commented Aug 16, 2024

[PM-10394] Add new item type ssh key #4575

Are you sure you want to change the base?

[PM-10394] Add new item type ssh key #4575

Conversation

quexten commented Aug 1, 2024 • edited Loading

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

codecov bot commented Aug 1, 2024 • edited Loading

Codecov Report

github-actions bot commented Aug 1, 2024 • edited Loading

New Issues

Fixed Issues

rawkode commented Aug 10, 2024

quexten commented Aug 16, 2024

quexten commented Aug 1, 2024 •

edited

Loading

codecov bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading