Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Cover code with tests #122

Draft
wants to merge 70 commits into
base: main
Choose a base branch
from
Draft

[WIP] Cover code with tests #122

wants to merge 70 commits into from

Conversation

bivashy
Copy link
Owner

@bivashy bivashy commented Nov 22, 2023

Pull Request Etiquette

  • I have checked the PRs for upcoming features/bug fixes.

Changes

  • Internal code
  • API (affecting end-user code)
  • Other: Build files (pom.xml and etc.)

Closes Issue: #45

Description

This Pull Request covers codebase with tests using JUnit5, JUnit Jupiter, Mockito.
Uses SQLite driver for 'launching' plugin instance.

bivashy added 30 commits June 2, 2023 23:31
@bivashy
Add Mockito, JUnit Jupiter, maven surefire
56e1194
@bivashy
Fix junit5 dependency, use mockito junit5 extension
783cf2d
@bivashy
Add tests for crypto package
4231504
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
d0d29bc
@bivashy
Make tests for FolderResource, DefaultResource
f2ec69d
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
20abd95
@bivashy
Fix JarResourcesTest
20f268a
@bivashy
Create BaseAuthPluginTest
d96f2c3
@bivashy
Create ConfiguratePluginConfigTest
20f75a8
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
f396150
@bivashy
Prevent NullPointerException on unresolved player InetAddress
7d3dadb
@bivashy
Revert "Prevent NullPointerException on unresolved player InetAddress"
feab17b 
This reverts commit 7d3dadb.
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
8c7536c
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
2fa6f66
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
2793f74
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
979caea
@bivashy
Append #testExampleConfigurationValues with LinkCommandPath test
73c1abb
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
a011b35
@bivashy
Remove PluginConfig#getPasswordPattern from tests
7ce5ff3
@bivashy
Use @ExtendWith(MockitoExtension) instead of MockitoAnnotations#openM…
83f2646 
…ocks
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
aac56f2
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
e42817c
@bivashy
Remove unnecessary stubbing
9ad81a7
@bivashy
Add AuthAccountFactoryTest
127850b
@bivashy
Add AuthAccountTest
b197b29
@bivashy
Remove unnecessary check from EnterAuthServerAuthenticationStep, Logi…
9c1b461 
…nAuthenticationStep
@bivashy
Replace Account#isSessionActive by haveSession method
432b3e0
@bivashy
Revert "Replace Account#isSessionActive by haveSession method"
7dba832 
This reverts commit 432b3e0.
@bivashy
Revert "Remove unnecessary check from EnterAuthServerAuthenticationSt…
31cb0c5 
…ep, LoginAuthenticationStep"

This reverts commit 9c1b461.
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
687221b
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
8aae14e 
# Conflicts:
#	core/pom.xml
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
8999e2b
@bivashy
Move AccountDatabase#deleteAccount into step tests in AuthAccountTest
115b51b
@bivashy
Add "wrong" account scenario into AuthenticatingAccountBucketTest
6578189
@bivashy
Added AuthenticationStepFactoryBucketTest
b43766a
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
ed1fbee
@bivashy
Replace assertEquals(0, list.size()) with assertTrue(list.isEmpty())
ded45df
@bivashy
Added AuthenticationTaskBucketTest
6d70cb0
@bivashy
Added CryptoProviderBucketTest
e4fe321
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
bae577d
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
b7f09ff
@bivashy
Add AccountDatabase 'lazy-load' support into AuthAccountTest
279263b
@bivashy
Add missing CryptoProviderBucket#addCryptoProvider in CryptoProviderB…
f29da87 
…ucketTest
@bivashy
Added SimpleBucketTest
fb6c432
@bivashy
Rewrite AuthenticationTaskBucketTest extending SimpleBucketTest
a80c132
@bivashy
Added LinkConfirmationBucketTest
d9a3e94
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
5b54831
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
45c2e74 
# Conflicts:
#	core/pom.xml
@bivashy
Remove redundant properties
2d746dd
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
4ff71e8
@bivashy
Replace BucketAdapter with internal api
2b6399f
@bivashy
Implement SimpleBucketTest in bucket tests
fdf120a
@bivashy
Remove redundant lazy loading in AuthAccountTest
c41c4db
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
835285d 
# Conflicts:
#	core/pom.xml
@bivashy bivashy linked an issue Nov 22, 2023 that may be closed by this pull request
[Suggestion] Add tests #45
Open
@bivashy bivashy changed the title Add tests Cover code with tests Nov 22, 2023
@bivashy bivashy changed the title Cover code with tests [WIP] Cover code with tests Dec 11, 2023
@bivashy
Merge branch 'main' into 45-suggestion-add-tests
b751c86 
# Conflicts:
#	core/pom.xml
#	pom.xml
@bivashy
Fix tests incompatibility with main merge
097a0b0 
Fixed:
  - Password4j 1.7.3 UTF-8 usage instead of ISO 8859-1
  - Misspelling in AuthAccountTest, where CryptoProvider was removed instead of adding into the bucket
  - MiniMessage json message
@bivashy
Code formatting in crypto provider tests
f06675f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Suggestion] Add tests
1 participant
@bivashy