Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Cover code with tests #122

Draft
wants to merge 70 commits into
base: main
Choose a base branch
from
Draft

[WIP] Cover code with tests #122

wants to merge 70 commits into from

Commits on Jun 2, 2023

  1. Add Mockito, JUnit Jupiter, maven surefire

    @bivashy
    bivashy committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    56e1194 View commit details
    Browse the repository at this point in the history

  2. Fix junit5 dependency, use mockito junit5 extension

    @bivashy
    bivashy committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    783cf2d View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. Add tests for crypto package

    @bivashy
    bivashy committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    4231504 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    d0d29bc View commit details
    Browse the repository at this point in the history

  2. Make tests for FolderResource, DefaultResource

    @bivashy
    bivashy committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    f2ec69d View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    20abd95 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Fix JarResourcesTest

    @bivashy
    bivashy committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    20f268a View commit details
    Browse the repository at this point in the history

  2. Create BaseAuthPluginTest

    @bivashy
    bivashy committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    d96f2c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Create ConfiguratePluginConfigTest

    @bivashy
    bivashy committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    20f75a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    f396150 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Prevent NullPointerException on unresolved player InetAddress

    @bivashy
    bivashy committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    7d3dadb View commit details
    Browse the repository at this point in the history

  2. Revert "Prevent NullPointerException on unresolved player InetAddress" 

    This reverts commit 7d3dadb.
    @bivashy
    bivashy committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    feab17b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    8c7536c View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    2fa6f66 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    2793f74 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    979caea View commit details
    Browse the repository at this point in the history

  2. Append #testExampleConfigurationValues with LinkCommandPath test

    @bivashy
    bivashy committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    73c1abb View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a011b35 View commit details
    Browse the repository at this point in the history

  2. Remove PluginConfig#getPasswordPattern from tests

    @bivashy
    bivashy committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    7ce5ff3 View commit details
    Browse the repository at this point in the history

  3. Use @ExtendWith(MockitoExtension) instead of MockitoAnnotations#openM… 

    …ocks
    @bivashy
    bivashy committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    83f2646 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    aac56f2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    e42817c View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary stubbing

    @bivashy
    bivashy committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    9ad81a7 View commit details
    Browse the repository at this point in the history

  7. Add AuthAccountFactoryTest

    @bivashy
    bivashy committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    127850b View commit details
    Browse the repository at this point in the history

  8. Add AuthAccountTest

    @bivashy
    bivashy committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    b197b29 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Remove unnecessary check from EnterAuthServerAuthenticationStep, Logi… 

    …nAuthenticationStep
    @bivashy
    bivashy committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    9c1b461 View commit details
    Browse the repository at this point in the history

  2. Replace Account#isSessionActive by haveSession method

    @bivashy
    bivashy committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    432b3e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2023

  1. Revert "Replace Account#isSessionActive by haveSession method" 

    This reverts commit 432b3e0.
    @bivashy
    bivashy committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    7dba832 View commit details
    Browse the repository at this point in the history

  2. Revert "Remove unnecessary check from EnterAuthServerAuthenticationSt… 

    …ep, LoginAuthenticationStep"

This reverts commit 9c1b461.
    @bivashy
    bivashy committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    31cb0c5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    687221b View commit details
    Browse the repository at this point in the history

  4. Replace BaseAuthPluginTest#createCachedJdbcDriver with maven dependency

    @bivashy
    bivashy committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    8dd6d87 View commit details
    Browse the repository at this point in the history

  5. Set pluginFolder cleanup NEVER in BaseAuthPluginTest

    @bivashy
    bivashy committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    472be09 View commit details
    Browse the repository at this point in the history

  6. Rename test methods in BaseAuthPluginTest

    @bivashy
    bivashy committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    0e680ff View commit details
    Browse the repository at this point in the history

  7. Add authentication step tests into AuthAccountTest

    @bivashy
    bivashy committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    010b2f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests 

    # Conflicts:
#	core/pom.xml
    @bivashy
    bivashy committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    5a2c4ed View commit details
    Browse the repository at this point in the history

  2. Add LibraryManagement as constructor parameter in BaseAuthPluginTest

    @bivashy
    bivashy committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    708fcfb View commit details
    Browse the repository at this point in the history

  3. Add more clarification to the BaseAuthPluginTest.java#shouldHaveValid… 

    …BucketSize
    @bivashy
    bivashy committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2cb998f View commit details
    Browse the repository at this point in the history

  4. Add AuthenticatingAccountBucketTest

    @bivashy
    bivashy committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    c99abff View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Remove MessageReceivedEvent handling in JDACommandListener

    @bivashy
    bivashy committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    5caa29b View commit details
    Browse the repository at this point in the history

  2. Move channel validation from JDACommandListener into DiscordCommandRe… 

    …gistry
    @bivashy
    bivashy committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    704f0a1 View commit details
    Browse the repository at this point in the history

  3. Rewrite LinkCodeCommand registration in ServerCommandsRegistry

    @bivashy
    bivashy committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    db2b217 View commit details
    Browse the repository at this point in the history

  4. Mention proper command in confirmation-no-code message

    @bivashy
    bivashy committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    f6ed863 View commit details
    Browse the repository at this point in the history

  5. Do not throw exception if LinkUser was not found. Replace field with … 

    …getLinkUser() method
    @bivashy
    bivashy committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    3eab360 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into 45-suggestion-add-tests 

    # Conflicts:
#	core/pom.xml
    @bivashy
    bivashy committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    8aae14e View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    8999e2b View commit details
    Browse the repository at this point in the history

  2. Move AccountDatabase#deleteAccount into step tests in AuthAccountTest

    @bivashy
    bivashy committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    115b51b View commit details
    Browse the repository at this point in the history

  3. Add "wrong" account scenario into AuthenticatingAccountBucketTest

    @bivashy
    bivashy committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6578189 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Added AuthenticationStepFactoryBucketTest

    @bivashy
    bivashy committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b43766a View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ed1fbee View commit details
    Browse the repository at this point in the history

  2. Replace assertEquals(0, list.size()) with assertTrue(list.isEmpty())

    @bivashy
    bivashy committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ded45df View commit details
    Browse the repository at this point in the history

  3. Added AuthenticationTaskBucketTest

    @bivashy
    bivashy committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    6d70cb0 View commit details
    Browse the repository at this point in the history

  4. Added CryptoProviderBucketTest

    @bivashy
    bivashy committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e4fe321 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    bae577d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    b7f09ff View commit details
    Browse the repository at this point in the history

  3. Add AccountDatabase 'lazy-load' support into AuthAccountTest

    @bivashy
    bivashy committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    279263b View commit details
    Browse the repository at this point in the history

  4. Add missing CryptoProviderBucket#addCryptoProvider in CryptoProviderB… 

    …ucketTest
    @bivashy
    bivashy committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    f29da87 View commit details
    Browse the repository at this point in the history

  5. Added SimpleBucketTest

    @bivashy
    bivashy committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    fb6c432 View commit details
    Browse the repository at this point in the history

  6. Rewrite AuthenticationTaskBucketTest extending SimpleBucketTest

    @bivashy
    bivashy committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    a80c132 View commit details
    Browse the repository at this point in the history

  7. Added LinkConfirmationBucketTest

    @bivashy
    bivashy committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    d9a3e94 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    5b54831 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests 

    # Conflicts:
#	core/pom.xml
    @bivashy
    bivashy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    45c2e74 View commit details
    Browse the repository at this point in the history

  2. Remove redundant properties

    @bivashy
    bivashy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    2d746dd View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests

    @bivashy
    bivashy committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    4ff71e8 View commit details
    Browse the repository at this point in the history

  2. Replace BucketAdapter with internal api

    @bivashy
    bivashy committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    2b6399f View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Implement SimpleBucketTest in bucket tests

    @bivashy
    bivashy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    fdf120a View commit details
    Browse the repository at this point in the history

  2. Remove redundant lazy loading in AuthAccountTest

    @bivashy
    bivashy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c41c4db View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Merge branch 'main' into 45-suggestion-add-tests 

    # Conflicts:
#	core/pom.xml
    @bivashy
    bivashy committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    835285d View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Merge branch 'main' into 45-suggestion-add-tests 

    # Conflicts:
#	core/pom.xml
#	pom.xml
    @bivashy
    bivashy committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    b751c86 View commit details
    Browse the repository at this point in the history

  2. Fix tests incompatibility with main merge 

    Fixed:
  - Password4j 1.7.3 UTF-8 usage instead of ISO 8859-1
  - Misspelling in AuthAccountTest, where CryptoProvider was removed instead of adding into the bucket
  - MiniMessage json message
    @bivashy
    bivashy committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    097a0b0 View commit details
    Browse the repository at this point in the history

  3. Code formatting in crypto provider tests

    @bivashy
    bivashy committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    f06675f View commit details
    Browse the repository at this point in the history