Some more workflow fixes and updated .mod file #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt at compiling x86_64 and arm64 together in the same run, hopefully getting a single library compatible with both.
Trying wrapping the Maya 2024 macos architectures in quotes to fix build
Removing architecture from macos builds as it looks like targeting for both arm and x64 works in a single bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Slight change to workflows to attempt compiling 2024 macos bundle for both x86_64 and arm64. Tested and working correctly on Maya 2024 on an Intel Mac, unfortunately don't have access to a new M1 mac so can't test arm64, but the fact that it worked on Intel on a .bundle compiled for both makes me think it's probably fine.
Also modified the .mod file to reflect the latest changes, but didn't increase the version myself!