일기 작성 흐름 중 음악 검색 부분 작성 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LEEYOONJONG
reviewed
Dec 7, 2022
| switch $0 { | ||
| case .success(let shazamSongDTO): | ||
| let musicInfo = MusicInfo(shazamSong: shazamSongDTO) | ||
| self.musicInfoResult.onNext(.success(musicInfo)) |
There was a problem hiding this comment.
이런 식으로 전달하는 게 최선이지 싶습니다,, 더 좋은 방법을 저도 못떠올리겟네요ㅠ
There was a problem hiding this comment.
이번주의 주제로 삼아 볼까 싶기도 합니다.. ㅋㅋㅋㅋ
LEEYOONJONG
approved these changes
Dec 7, 2022
rudah7
approved these changes
Dec 7, 2022
| @@ -102,7 +102,7 @@ final class LoginViewController: UIViewController { | |||
| let view = UIView() | |||
|
|
|||
| view.backgroundColor = .clear | |||
|
|
|||
| view.isUserInteractionEnabled = false | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12/6 #141 #156 #158
작업한 내용
음악 검색 흐름을 변경했습니다. ShazamSession을 Repository에서 가지고 있도록 변경했습니다.
덤 : 로그인 로직 시도해봤습니다. 잘 됩니다..?!
일기 작성 뷰 컨트롤러, 샤잠세션도 정리했습니다.
고민한 점 및 어려웠던 점
PublishSubject 프로퍼티의 연쇄로 값을 전달해야 하나 고민했습니다.