-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
일기 작성 흐름 중 음악 검색 부분 작성 #165
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
aaaaac7
feat: 검색을 수행하기 위해 일기 상세 뷰 모델 정의
radiantchoi 4a59dde
#156 feat: 일기 작성 뷰 모델에 필요한 메서드 및 UseCase 작성
radiantchoi c678c90
#158 feat: 일기 작성 뷰 컨트롤러와 일기 작성 뷰 모델 연결
radiantchoi 222b58f
#156 feat: 음악 검색 결과를 뷰 모델로부터 받아오는 로직 작성
radiantchoi 1fd2474
#156 #158 feat: 음악 검색을 중지했을 경우 작동하는 로직 작성
radiantchoi dedae99
refactor: 음악 검색 관련 로직의 흐름을 비워둔 상태로 재조정
radiantchoi 32746c3
#141 feat: 검색중 표시를 뷰 모델로 이관
radiantchoi 02aef9c
#141 feat: 전체적인 검색 로직 작성
radiantchoi c55eef5
#141 #156 #158 feat: 분리되어 있던 음악 검색 로직 연결
radiantchoi bf2b6c8
refactor: ShazamSession 내부 정리
radiantchoi 8f3e834
fix: 로그인 뷰 컨트롤러에서 버튼을 눌러도 응답이 없는 부분 수정
radiantchoi 8dce2f1
refactor: 일기 작성 뷰 컨트롤러 메서드 이름 조정, 고정값 Metric으로 이동
radiantchoi cd0fd14
Merge branch 'develop' into feature/diary-edit-flow
radiantchoi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// | ||
// ShazamError.swift | ||
// Segno | ||
// | ||
// Created by Gordon Choi on 2022/12/07. | ||
// | ||
|
||
import Foundation | ||
|
||
enum ShazamError: Error, LocalizedError { | ||
case recordDenied | ||
case unknown | ||
case matchFailed | ||
|
||
var errorDescription: String { | ||
switch self { | ||
case .recordDenied: | ||
return "Record permission is denied. Please enable it in Settings." | ||
case .matchFailed: | ||
return "No song found or internet connection is bad." | ||
case .unknown: | ||
return "Unknown error occured." | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// | ||
// ShazamSongDTO.swift | ||
// Segno | ||
// | ||
// Created by Gordon Choi on 2022/12/07. | ||
// | ||
|
||
import Foundation | ||
import ShazamKit | ||
|
||
struct ShazamSongDTO { | ||
let isrc: String | ||
let title: String | ||
let artist: String | ||
let album: String | ||
let imageURL: URL? | ||
|
||
init?(mediaItem: SHMatchedMediaItem) { | ||
guard let isrc = mediaItem.isrc, | ||
let title = mediaItem.title, | ||
let artist = mediaItem.artist, | ||
let album = mediaItem.album | ||
else { return nil } | ||
|
||
self.isrc = isrc | ||
self.title = title | ||
self.artist = artist | ||
self.album = album | ||
self.imageURL = mediaItem.artworkURL | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이런 식으로 전달하는 게 최선이지 싶습니다,, 더 좋은 방법을 저도 못떠올리겟네요ㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이번주의 주제로 삼아 볼까 싶기도 합니다.. ㅋㅋㅋㅋ