fix shadow index update for double-put (1.2-maint) #7896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the new test is currently failing due to a bug in the repository code.
this fixes the test added in previous commit (avoids that the PUT reappears after index rebuild).
no functional change here.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## 1.2-maint #7896 +/- ##
=============================================
- Coverage 82.60% 82.60% -0.01%
=============================================
Files 38 38
Lines 10776 10775 -1
Branches 2064 2063 -1
=============================================
- Hits 8902 8901 -1
Misses 1327 1327
Partials 547 547
|
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid future issues when borg issues a double-put (a put to a chunk id that already exists in the repo - AFAIK it only does that for borg recreate when changing compression and also for each manifest update - but in case of the manifest this maybe never triggered an issue because the manifest was usually written into an own small segment file).
When running borg in client/server mode (with a remote repo), the fix needs to get applied repo/server-side.