Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search fixes #929

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Search fixes #929

merged 2 commits into from
Sep 12, 2024

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Sep 11, 2024

Proposed Changes

brave_rL206TWcO6

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 11, 2024
@nikku
Copy link
Member

nikku commented Sep 12, 2024

Try out via npx @bpmn-io/sr -l bpmn-io/diagram-js#search-fixes bpmn-io/bpmn-js.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@nikku nikku merged commit b6ee0d5 into develop Sep 12, 2024
8 of 10 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 12, 2024
@nikku nikku deleted the search-fixes branch September 12, 2024 11:23
@nikku nikku mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants