Add support for paying to BOLT12 #549
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
requested changes
Nov 6, 2024
dangeross
reviewed
Nov 12, 2024
Co-authored-by: Ross Savage <[email protected]>
# Conflicts: # cli/src/commands.rs # lib/core/src/sdk.rs
Don't try to extract invoice description, because it is added later during persist.
dangeross
reviewed
Nov 13, 2024
Comment on lines
+868
to
+870
| _ => Err(PaymentError::amount_missing( | ||
| "Expected PayAmount of type Receiver when processing a Bolt12 offer", | ||
| )), |
There was a problem hiding this comment.
I think it's fine to not handle the drain case now, there are issues to inverse calculate the Boltz fee #559.
Co-authored-by: Ross Savage <[email protected]>
MRH with Bolt12 is not possible because receive is not yet supported.
Removed self-transfer check TODO, because self-transfers are not possible with Bolt12 when receive is not supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for paying to a BOLT12 offer.
The flow is as follows:
send_payment_via_swapwith the BOLT12 invoice as argument, instead of the usual BOLT11Open questions
PaymentDetails::Lightningwith a new field forbolt12_invoice? And / or an optionalbolt12_offer?bolt11field toinvoice, so it means either BOLT11 or BOLT12 invoice?prepare? This may take a long time for slow endpoints (Phoenix), causing the user to wait a few seconds forprepareto return.sdk_common::input_parserto parse BOLT12 offers / invoice? Or keep changes local to the Liquid SDK?Open TODOs
Detect / handle MRH in BOLT12 invoiceslist_paymentsshows payments asPendinglist_paymentsshows the bolt12 invoice underbolt11(should show offer instead)