Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for paying to BOLT12 #549

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Add support for paying to BOLT12 #549

wants to merge 23 commits into from

Commits on Nov 6, 2024

  1. Add initial version of paying to a BOLT12 offer

    @ok300
    ok300 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1e1a00d View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Bump sdk-common

    @ok300
    ok300 committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    06e6529 View commit details
    Browse the repository at this point in the history

  2. SendDestination: Bolt12 type stores amount in addition to offer

    @ok300
    ok300 committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    f4d6a3b View commit details
    Browse the repository at this point in the history

  3. prepare_send_payment: remove fetching Bolt12 invoice

    @ok300
    ok300 committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    5521b1e View commit details
    Browse the repository at this point in the history

  4. Re-generate RN bindings

    @ok300
    ok300 committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    8244e1c View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Bump sdk-common with new Bolt12Offer(String)

    @ok300
    ok300 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e76c8f9 View commit details
    Browse the repository at this point in the history

  2. Update lib/core/src/sdk.rs 

    Co-authored-by: Ross Savage <[email protected]>
    @ok300 @dangeross
    ok300 and dangeross authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    47841e4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ok300-add-bolt12 

    # Conflicts:
#	cli/src/commands.rs
#	lib/core/src/sdk.rs
    @ok300
    ok300 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    96a12b2 View commit details
    Browse the repository at this point in the history

  4. Re-generate RN bindings

    @ok300
    ok300 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f5839e6 View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @ok300
    ok300 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    68449c2 View commit details
    Browse the repository at this point in the history

  6. Address invoice description persistence 

    Don't try to extract invoice description, because it is added later during persist.
    @ok300
    ok300 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    790d8f2 View commit details
    Browse the repository at this point in the history

  7. Bump sdk-common to use new InputType variant

    @ok300
    ok300 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    0219b99 View commit details
    Browse the repository at this point in the history

  8. Cargo fmt

    @ok300
    ok300 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    690e2e6 View commit details
    Browse the repository at this point in the history

  9. Bump sdk-common to include fixed type reference

    @ok300
    ok300 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    43a0bfe View commit details
    Browse the repository at this point in the history

  10. Update SendDestination::Bolt12 to include LNOffer

    @ok300
    ok300 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    bb18d10 View commit details
    Browse the repository at this point in the history

  11. Re-generate RN bindings

    @ok300
    ok300 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4a53177 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Bump sdk-common, propagate changes

    @ok300
    ok300 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2928ed9 View commit details
    Browse the repository at this point in the history

  2. Update cli/src/commands.rs 

    Co-authored-by: Ross Savage <[email protected]>
    @ok300 @dangeross
    ok300 and dangeross authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f9b9d54 View commit details
    Browse the repository at this point in the history

  3. Bump sdk-common, propagate changes

    @ok300
    ok300 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    10fbefa View commit details
    Browse the repository at this point in the history

  4. Clarify CLI invoice description

    @ok300
    ok300 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9ae1f6c View commit details
    Browse the repository at this point in the history

  5. Address MRH TODO 

    MRH with Bolt12 is not possible because receive is not yet supported.
    @ok300
    ok300 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    83ccce0 View commit details
    Browse the repository at this point in the history

  6. Address self-transfer TODO 

    Removed self-transfer check TODO, because self-transfers are not possible with Bolt12 when receive is not supported.
    @ok300
    ok300 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b54da49 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Add Bolt12 invoice validation before paying

    @ok300
    ok300 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6be99de View commit details
    Browse the repository at this point in the history