Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPD-32573 Use the url mapping to avoid missing parameters on language change #154328

Closed
wants to merge 3 commits into from
Closed

LPD-32573 Use the url mapping to avoid missing parameters on language change #154328

wants to merge 3 commits into from

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-content-management#5862 (Took 3 ci:forward attempts in 1 day 22 hours 46 minutes)
Console

@robertoDiaz
@liferay-content-management

Original pull request comment:

What is this trying to solve?

https://liferay.atlassian.net/browse/LPD-32573

How am I fixing it?

Using the existing implementations of FriendlyURLMapper to get the full url and avoid missing parameters

How can you verify that it works?

Run the included automated tests.

@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@liferay-continuous-integration
Copy link
Collaborator Author

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bfddf4d2267afa49bd727d75e5910361130af3ad

Sender Branch:

Branch Name: LPD-32573
Branch GIT ID: f92d7ebfa49e8f9fe6bbb3d13d77c8aab3a6a7d9

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator Author

✔️ ci:test:stable - 27 out of 27 jobs passed

❌ ci:test:relevant - 146 out of 176 jobs passed in 5 hours 30 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2af8dabeca08eae444ee911387f043338ec7b2c3

Upstream Comparison:

Branch GIT ID: a3b9e6ea8e217048c7b911ca60ce7d4c920611b1
Jenkins Build URL: EE Development Acceptance (master) - 831 - 2024-09-16[12:59:20]

ci:test:stable - 27 out of 27 jobs PASSED
27 Successful Jobs:
    ci:test:relevant - 146 out of 176 jobs PASSED

    30 Failed Jobs:

    146 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      5. unit-jdk8/0/0
        1. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagInternalServerErrorResponseStatus - UNTESTED
        2. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagLayoutRobots - UNTESTED
        3. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagLocalizedLayoutRobots - UNTESTED
        4. ...

      Closed
      @brianchandotcom
      Copy link
      Owner

      @robertoDiaz can you merge the tests back together the way they were before. That's the preferred pattern so that integration tests run faster. yes, it's harder to debug, but I want to run speed.

      See robertoDiaz#909

      @brianchandotcom brianchandotcom mentioned this pull request Sep 19, 2024
      Open
      @robertoDiaz
      Copy link

      robertoDiaz commented Sep 19, 2024 •
      edited
      Loading

      Sure @brianchandotcom :)

      I'll remove my last commit and I'll resend

      @robertoDiaz robertoDiaz mentioned this pull request Sep 19, 2024
      Closed
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers
      No reviews
      Assignees
      No one assigned
      Labels
      None yet
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      3 participants
      @liferay-continuous-integration @brianchandotcom @robertoDiaz