LPD-32573 Use the url mapping to avoid missing parameters on language change #5862

robertoDiaz · 2024-09-12T10:55:57Z

What is this trying to solve?

https://liferay.atlassian.net/browse/LPD-32573

How am I fixing it?

Using the existing implementations of FriendlyURLMapper to get the full url and avoid missing parameters

How can you verify that it works?

Run the included automated tests.

… to make it clearer and safer.

liferay-continuous-integration · 2024-09-12T10:56:03Z

CI is automatically triggering the following test suites:

ci:test:sf

liferay-continuous-integration · 2024-09-12T11:01:19Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bfddf4d2267afa49bd727d75e5910361130af3ad

Sender Branch:

Branch Name: LPD-32573
Branch GIT ID: f92d7ebfa49e8f9fe6bbb3d13d77c8aab3a6a7d9

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2024-09-12T11:04:12Z

Jenkins Build:test-portal-source-format#8046

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-content-management#5862

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - robertoDiaz > liferay-content-management - PR#5862 - 2024-09-12[03:57:23]

Testray Build ID:9694787

Testray Importer:publish-testray-report#4420

robertoDiaz · 2024-09-12T11:05:30Z

ci:test:relevant

robertoDiaz · 2024-09-12T11:05:38Z

ci:test:content-management

liferay-continuous-integration · 2024-09-12T15:46:10Z

✔️ ci:test:stable - 27 out of 27 jobs passed

❌ ci:test:relevant - 146 out of 175 jobs passed in 3 hours 9 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bfddf4d2267afa49bd727d75e5910361130af3ad

Upstream Comparison:

Branch GIT ID: bfddf4d2267afa49bd727d75e5910361130af3ad
Jenkins Build URL: EE Development Acceptance (master) - 821 - 2024-09-11[22:14:36]

ci:test:stable - 27 out of 27 jobs PASSED

27 Successful Jobs:

ci:test:relevant - 146 out of 175 jobs PASSED

29 Failed Jobs:

146 Successful Jobs:

For more details click here.

Failures unique to this pull:

modules-integration-mysql57-jdk8/5/1
1. com.liferay.sharing.document.library.internal.display.context.test.SharingDLViewFileVersionDisplayContextTest - Failed 1 of last 15
  testGetActionDropdownItems
unit-jdk8/0/0
1. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagInternalServerErrorResponseStatus - UNTESTED
2. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagLayoutRobots - UNTESTED
3. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagLocalizedLayoutRobots - UNTESTED
4. ...

Failures in common with acceptance upstream results at bfddf4d:

liferay-continuous-integration · 2024-09-12T15:51:50Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6606

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-content-management#5862

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - robertoDiaz > liferay-content-management - PR#5862 - 2024-09-12[05:33:27]

Testray Build ID:10120153

Testray Importer:publish-testray-report#14523

liferay-continuous-integration · 2024-09-12T16:04:15Z

❌ ci:test:content-management - 916 out of 1026 jobs passed in 3 hours 36 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bfddf4d2267afa49bd727d75e5910361130af3ad

Upstream Comparison:

Branch GIT ID: bfddf4d2267afa49bd727d75e5910361130af3ad
Jenkins Build URL: EE Development Acceptance (master) - 821 - 2024-09-11[22:14:36]

ci:test:content-management - 916 out of 1026 jobs PASSED

110 Failed Jobs:

916 Successful Jobs:

For more details click here.

Failures unique to this pull:

functional-tomcat90-mysql57-jdk8/20/20

     [exec] * What went wrong:
     [exec] Execution failed for task ':runPoshi'.
     [exec] > There were failing tests. See the report at: file:///opt/dev/projects/github/liferay-portal/portal-web/tests/index.html
     [exec] 
     [exec] * Try:
     [exec] > Run with --scan to get full insights.
     [exec] 
     [exec] BUILD FAILED in 27s
     [exec] 3 actionable tasks: 2 executed, 1 up-to-date
     [exec] 
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/portal-web/build/reports/profile/profile-2024-09-12-06-54-10.html
     [exec] A fine-grained performance profile is available: use the --scan option.
     [exec] Result: 1
     [copy] Copying 1 file to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/1096252
     [copy] Copying 2 files to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/1096252/screenshots
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1284596395.properties
clean-up-selenium-driver:

[echo] Executing commands:

[echo]

[echo] docker logs test-1-31-73.lax.liferay.com_chrome > /tmp/jenkins/test-1-31/test-portal-acceptance-pullrequest-downstream(master)/1096252/docker-logs/test-1-31-73.lax.liferay.com_chrome.log

[echo]

[echo] https://test-1-37.liferay.com/userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/17906/functional-tomcat90-mysql57-jdk8/20/20/docker-logs/test-1-31-73.lax.liferay.com_chrome.log

[echo] Executing commands:

[echo] killall chromedriver

[exec] chromedriver: no process found

[exec] Result: 1

[stopwatch] [test.execution.duration: 5:57.024 sec]

[stopwatch] [run.batch.test.action: 6:26.690 sec]

[echo] The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:373: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1685: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1689: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:38: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:50: The following error occurred while executing this line:

LocalFile.CPSharepoint2013#CheckinDocument - Poshi Report - Poshi Summary - Poshi Console - Console Output - Liferay Log

functional-tomcat90-mysql57-jdk8/20/21

     [exec] * What went wrong:

[exec] Execution failed for task ':runPoshi'.

[exec] > There were failing tests. See the report at: file:///opt/dev/projects/github/liferay-portal/portal-web/tests/index.html

[exec]

[exec] * Try:

[exec] > Run with --scan to get full insights.

[exec]

[exec] BUILD FAILED in 29s

[exec] Result: 1

[copy] Copying 1 file to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/732567

[copy] Copying 2 files to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/732567/screenshots

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null1288332723.properties
clean-up-selenium-driver:

[echo] Executing commands:

[echo]

[echo] docker logs test-1-40-60.lax.liferay.com_chrome > /tmp/jenkins/test-1-40/test-portal-acceptance-pullrequest-downstream(master)/732567/docker-logs/test-1-40-60.lax.liferay.com_chrome.log

[echo]

[echo] https://test-1-37.liferay.com/userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/17906/functional-tomcat90-mysql57-jdk8/20/21/docker-logs/test-1-40-60.lax.liferay.com_chrome.log

[echo] Executing commands:

[echo] killall chromedriver

[exec] chromedriver: no process found

[exec] Result: 1

[stopwatch] [test.execution.duration: 4:31.029 sec]

[stopwatch] [run.batch.test.action: 5:00.911 sec]

[echo] The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:373: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1685: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1689: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:38: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:50: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test.xml:16672: Property custom.default.user.password was circularly defined.

[get] Getting: ${dependencies.url}/archive/test-1-40/test-portal-acceptance-pullrequest-downstream(master)/732567consoleText

[get] To: /opt/dev/projects/github/liferay-portal/20240912065139190.txt

LocalFile.CPSharepoint2013#DeleteDocumentInSubfolder - Poshi Report - Poshi Summary - Poshi Console - Console Output - Liferay Log

functional-tomcat90-mysql57-jdk8/20/22

     [exec] * What went wrong:

[exec] Execution failed for task ':runPoshi'.

[exec] > There were failing tests. See the report at: file:///opt/dev/projects/github/liferay-portal/portal-web/tests/index.html

[exec]

[exec] * Try:

[exec] > Run with --scan to get full insights.

[exec]

[exec] BUILD FAILED in 27s

[exec] Result: 1

[copy] Copying 1 file to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/942308

[copy] Copying 2 files to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/942308/screenshots

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null830134281.properties
clean-up-selenium-driver:

[echo] Executing commands:

[echo]

[echo] docker logs test-1-35-15.lax.liferay.com_chrome > /tmp/jenkins/test-1-35/test-portal-acceptance-pullrequest-downstream(master)/942308/docker-logs/test-1-35-15.lax.liferay.com_chrome.log

[echo]

[echo] https://test-1-37.liferay.com/userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/17906/functional-tomcat90-mysql57-jdk8/20/22/docker-logs/test-1-35-15.lax.liferay.com_chrome.log

[echo] Executing commands:

[echo] killall chromedriver

[exec] chromedriver: no process found

[exec] Result: 1

[stopwatch] [test.execution.duration: 4:24.125 sec]

[stopwatch] [run.batch.test.action: 4:53.852 sec]

[echo] The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:373: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1685: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1689: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:38: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:50: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test.xml:16672: Property custom.default.user.password was circularly defined.

[get] Getting: ${dependencies.url}/archive/test-1-35/test-portal-acceptance-pullrequest-downstream(master)/942308consoleText

[get] To: /opt/dev/projects/github/liferay-portal/20240912065226684.txt

LocalFile.CPSharepoint2013#DeleteSubfolder - Poshi Report - Poshi Summary - Poshi Console - Console Output - Liferay Log

functional-tomcat90-mysql57-jdk8/20/23

     [exec] * What went wrong:

[exec] Execution failed for task ':runPoshi'.

[exec] > There were failing tests. See the report at: file:///opt/dev/projects/github/liferay-portal/portal-web/tests/index.html

[exec]

[exec] * Try:

[exec] > Run with --scan to get full insights.

[exec]

[exec] BUILD FAILED in 41s

[exec] Result: 1

[copy] Copying 1 file to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/361586

[copy] Copying 2 files to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/361586/screenshots

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null1654078865.properties
clean-up-selenium-driver:

[echo] Executing commands:

[echo]

[echo] docker logs cloud-10-0-16-6.lax.liferay.com_chrome > /tmp/jenkins/test-1-1/test-portal-acceptance-pullrequest-downstream(master)/361586/docker-logs/cloud-10-0-16-6.lax.liferay.com_chrome.log

[echo]

[echo] https://test-1-37.liferay.com/userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/17906/functional-tomcat90-mysql57-jdk8/20/23/docker-logs/cloud-10-0-16-6.lax.liferay.com_chrome.log

[echo] Executing commands:

[echo] killall chromedriver

[exec] chromedriver: no process found

[exec] Result: 1

[stopwatch] [test.execution.duration: 7:33.159 sec]

[stopwatch] [run.batch.test.action: 8:16.764 sec]

[echo] The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:373: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1685: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1689: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:38: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:50: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test.xml:16672: Property custom.default.user.password was circularly defined.

[get] Getting: ${dependencies.url}/archive/test-1-1/test-portal-acceptance-pullrequest-downstream(master)/361586consoleText

[get] To: /opt/dev/projects/github/liferay-portal/20240912070058184.txt

LocalFile.CPSharepoint2013#EditDocumentFile - Poshi Report - Poshi Summary - Poshi Console - Console Output - Liferay Log

functional-tomcat90-mysql57-jdk8/20/24

     [exec] * What went wrong:

[exec] Execution failed for task ':runPoshi'.

[exec] > There were failing tests. See the report at: file:///opt/dev/projects/github/liferay-portal/portal-web/tests/index.html

[exec]

[exec] * Try:

[exec] > Run with --scan to get full insights.

[exec]

[exec] BUILD FAILED in 33s

[exec] Gradle build finished at 2024-09-12 13:56:47.739.

[exec] 3 actionable tasks: 2 executed, 1 up-to-date

[exec]

[exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/portal-web/build/reports/profile/profile-2024-09-12-06-56-18.html

[exec] A fine-grained performance profile is available: use the --scan option.

[exec] Result: 1

[copy] Copying 1 file to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/972542

[copy] Copying 2 files to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/972542/screenshots

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null147396319.properties
clean-up-selenium-driver:

[echo] Executing commands:

[echo]

[echo] docker logs test-1-28-38.lax.liferay.com_chrome > /tmp/jenkins/test-1-28/test-portal-acceptance-pullrequest-downstream(master)/972542/docker-logs/test-1-28-38.lax.liferay.com_chrome.log

[echo]

[echo] https://test-1-37.liferay.com/userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/17906/functional-tomcat90-mysql57-jdk8/20/24/docker-logs/test-1-28-38.lax.liferay.com_chrome.log

[echo] Executing commands:

[echo] killall chromedriver

[exec] chromedriver: no process found

[exec] Result: 1

[stopwatch] [test.execution.duration: 6:22.299 sec]

[stopwatch] [run.batch.test.action: 6:52.547 sec]

[echo] The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:373: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1685: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1689: The following error occurred while executing this line:

[echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:38: The following error occurred while executing this line:

LocalFile.CPSharepoint2013#EditRepository - Poshi Report - Poshi Summary - Poshi Console - Console Output - Liferay Log

...

liferay-continuous-integration · 2024-09-12T16:15:20Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#17906

Jenkins Report:jenkins-report.html

Jenkins Suite:content-management

Pull Request:liferay-content-management#5862

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:content-management - robertoDiaz > liferay-content-management - PR#5862 - 2024-09-12[05:27:43]

Testray Build ID:10210294

Testray Importer:publish-testray-report#38755

adolfopa · 2024-09-17T08:36:36Z

ci:forward

robertoDiaz · 2024-09-17T15:15:55Z

ci:forward

liferay-continuous-integration · 2024-09-17T15:16:06Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf
ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2024-09-17T15:16:06Z

Skipping previously passed test suites:

ci:test:sf
ci:test:stable

liferay-continuous-integration · 2024-09-17T20:48:23Z

✔️ ci:test:stable - 27 out of 27 jobs passed

❌ ci:test:relevant - 146 out of 176 jobs passed in 5 hours 30 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2af8dabeca08eae444ee911387f043338ec7b2c3

Upstream Comparison:

Branch GIT ID: a3b9e6ea8e217048c7b911ca60ce7d4c920611b1
Jenkins Build URL: EE Development Acceptance (master) - 831 - 2024-09-16[12:59:20]

ci:test:stable - 27 out of 27 jobs PASSED

27 Successful Jobs:

ci:test:relevant - 146 out of 176 jobs PASSED

30 Failed Jobs:

146 Successful Jobs:

For more details click here.

Failures unique to this pull:

modules-integration-mysql57-jdk8/3/19
```
Build was aborted
```
modules-integration-mysql57-jdk8/0/19
1. com.liferay.change.tracking.internal.test.PublicationUserNotificationHandlerTest - Failed 5 of last 18
  testGetLinkToViewConflicts
  testGetLinkToViewStackTrace
modules-integration-mysql57-jdk8/3/1
1. com.liferay.layout.admin.web.internal.portlet.action.test.AddContentLayoutMVCActionCommandCopyCategoriesAndTagsTest - Failed 0 of last 18
  testAddContentLayoutCopyAssetCategoriesAndAssetTags
2. com.liferay.layout.admin.web.internal.exportimport.data.handler.test.LayoutStagedModelDataHandlerTest - Failed 0 of last 18
  testCleanAssetCategoriesAndTags
  testStagedModelDataHandler
modules-integration-mysql57-jdk8/3/20
1. com.liferay.object.rest.internal.resource.v1_0.test.OpenAPIResourceTest - Failed 11 of last 15
  testGetOpenAPI
  testGetOpenAPIWithActions
unit-jdk8/0/0
1. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagInternalServerErrorResponseStatus - UNTESTED
2. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagLayoutRobots - UNTESTED
3. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagLocalizedLayoutRobots - UNTESTED
4. ...

liferay-continuous-integration · 2024-09-17T20:55:23Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#11025

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-content-management#5862

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - robertoDiaz > liferay-content-management - PR#5862 - 2024-09-17[08:16:13]

Testray Build ID:13709689

Testray Importer:publish-testray-report#23761

robertoDiaz · 2024-09-18T07:19:28Z

ci:report:13709689

liferay-continuous-integration · 2024-09-18T09:17:52Z

Build completed.

Testray CSV has been generated successfully for testrayBuildID: 13709689.

Job Link: generate-testray-csv

Testray CSV Link: testray-results-13709689.csv

robertoDiaz · 2024-09-18T15:59:28Z

@adolfopa Test seem unrelated.

adolfopa · 2024-09-19T07:21:56Z

ci:forward:force

liferay-continuous-integration · 2024-09-19T07:22:00Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf
ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

ci:test:relevant
ci:test:sf
AND If the following test suites pass:
ci:test:stable

liferay-continuous-integration · 2024-09-19T07:22:01Z

Skipping previously completed test suites:

ci:test:relevant
ci:test:sf
AND Skipping previously passed test suites:
ci:test:stable

liferay-continuous-integration · 2024-09-19T07:22:45Z

All required test suite(s) completed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2024-09-19T07:23:41Z

Pull request has been successfully forwarded to brianchandotcom#154328
Console

robertoDiaz added 3 commits September 12, 2024 12:44

LPD-32573 Use the url mapping

0c47013

LPD-32573 Add tests

a2d5515

LPD-32573 Improve test. Make test atomic, rename and create constants…

f92d7eb

… to make it clearer and safer.

liferay-content-management added the 🔍 backend review needed label Sep 12, 2024

liferay-continuous-integration added the ci:test:sf - pending label Sep 12, 2024

robertoDiaz changed the title ~~LPD-32573~~ LPD-32573 Use the url mapping to avoid missing parameters on language change Sep 12, 2024

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels Sep 12, 2024

liferay-continuous-integration added ci:test:content-management - pending ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Sep 12, 2024

liferay-continuous-integration added ci:test:content-management - failure and removed ci:test:content-management - pending labels Sep 12, 2024

adolfopa approved these changes Sep 17, 2024

View reviewed changes

liferay-content-management added ⚠ missing tests ✅ ready to forward labels Sep 17, 2024

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Sep 17, 2024

liferay-continuous-integration added the ci:test - pending label Sep 18, 2024

liferay-continuous-integration added ci:test - success and removed ci:test - pending labels Sep 18, 2024

liferay-content-management added the ⚠ forced label Sep 19, 2024

liferay-continuous-integration mentioned this pull request Sep 19, 2024

LPD-32573 Use the url mapping to avoid missing parameters on language change brianchandotcom/liferay-portal#154328

Closed

liferay-continuous-integration added the ci:forward:force label Sep 19, 2024

liferay-continuous-integration closed this Sep 19, 2024

LPD-32573 Use the url mapping to avoid missing parameters on language change #5862

LPD-32573 Use the url mapping to avoid missing parameters on language change #5862

Conversation

robertoDiaz commented Sep 12, 2024 • edited Loading

What is this trying to solve?

How am I fixing it?

How can you verify that it works?

liferay-continuous-integration commented Sep 12, 2024

liferay-continuous-integration commented Sep 12, 2024

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Sep 12, 2024

robertoDiaz commented Sep 12, 2024

robertoDiaz commented Sep 12, 2024

liferay-continuous-integration commented Sep 12, 2024

✔️ ci:test:stable - 27 out of 27 jobs passed

❌ ci:test:relevant - 146 out of 175 jobs passed in 3 hours 9 minutes

Base Branch:

Upstream Comparison:

29 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Sep 12, 2024

liferay-continuous-integration commented Sep 12, 2024

❌ ci:test:content-management - 916 out of 1026 jobs passed in 3 hours 36 minutes

Base Branch:

Upstream Comparison:

110 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Sep 12, 2024

adolfopa commented Sep 17, 2024

robertoDiaz commented Sep 17, 2024

liferay-continuous-integration commented Sep 17, 2024

liferay-continuous-integration commented Sep 17, 2024

liferay-continuous-integration commented Sep 17, 2024

✔️ ci:test:stable - 27 out of 27 jobs passed

❌ ci:test:relevant - 146 out of 176 jobs passed in 5 hours 30 minutes

Base Branch:

Upstream Comparison:

30 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Sep 17, 2024

robertoDiaz commented Sep 18, 2024

liferay-continuous-integration commented Sep 18, 2024

Build completed.

robertoDiaz commented Sep 18, 2024

adolfopa commented Sep 19, 2024

liferay-continuous-integration commented Sep 19, 2024

liferay-continuous-integration commented Sep 19, 2024

liferay-continuous-integration commented Sep 19, 2024

liferay-continuous-integration commented Sep 19, 2024

robertoDiaz commented Sep 12, 2024 •

edited

Loading