Update for editions #174
Merged
Update for editions #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodaine
approved these changes
Jul 26, 2024
jchadwick-buf
commented
Jul 27, 2024
Python is not particularly fast. The new test suites seem to run close to the timeout on GitHub actions, especially on older, slower Python versions, so let's increase the timeout a bit. While the Python protovalidate implementation could be faster, this is probably also reflective of GitHub Actions being somewhat slow, too.
Right now, it seems like it is not possible to implement field presence 100% accurately for protobuf types when using cel python, as the result of the `has` macro is tied to whether or not the expression in it can be evaluated. This fails in the protobuf case because `has` should be false in some cases even when a default value will be returned. This is a somewhat ugly workaround that patches the interpreter so we can track when we are inside of a `has` macro call and cause there to be an evaluation error if the field is unset.
|
OK, I think all outstanding issues should be resolved. I don't think we're in a rush to close this though so I'll leave some time for people to respond before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates protovalidate, adds support for new ignore semantics. The PR is huge but it's mostly gencode; the actual CEL code wasn't too substantially altered.
Unfortunately I could not get the tests to pass 100%. There is a minor wrinkle where, I believe, the behavior ofUpdate: The issues still exist upstream (assuming the issue is valid and not a mistake on my part) but we are now working around it, and tests now pass 100% (sans the existing failures.)has(x.y)andx.yneeds to differ (specifically with proto3 optional) but it can not due to the way the interpreter works. It seems like this only impacts some rather small edge cases so I guess we might be able to live with it in the interim. I've just added said tests to the nonconforming list.All other tests pass and I believe my fixes are correct. The e-mail check was corrected to not support bracketed emails as was done with the Go version.