Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Build Acceptance Tests #1498

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Simplify Build Acceptance Tests #1498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0fdb1ec
Migrate happy path build test to new acceptance suite
jromero Aug 11, 2022
c4d455d
Simplify usage via builder harness
jromero Aug 11, 2022
089d4fe
Further simplify usage of test harness, migrate more build tests
jromero Aug 11, 2022
8926c44
Merge branch 'main' into chore/acceptance-refactor
jromero Aug 11, 2022
2ec7376
Reorganize new acceptance suite package, migrate more build tests
jromero Aug 17, 2022
2c20968
Acceptance: Fix feature detection in pack
jromero Aug 20, 2022
99a1671
Migrate additional build acceptance tests
jromero Aug 20, 2022
34a1b61
Fix legacy acceptance tests
jromero Aug 20, 2022
d0188e8
Migrate rebase tests
jromero Aug 22, 2022
4ba458a
Update legacy acceptance tests to pass
jromero Aug 22, 2022
6a02bc9
make rebase tests windows compatible
jromero Aug 23, 2022
da00a5e
Improve test output by including combo in test path
jromero Aug 23, 2022
f676f3d
Update Makefile to execute legacy and new acceptance tests
jromero Aug 24, 2022
8542f63
Attempt to fix Windows CI issue
jromero Aug 24, 2022
4352bb6
Fix pack command detection in acceptance tests
jromero Aug 31, 2022
712d337
Tests: Increase docker client timeout to enable running all acceptanc…
jromero Sep 9, 2022
a520115
Merge branch 'main' into chore/acceptance-refactor
jromero Sep 9, 2022
8330cb9
Merge branch 'main' into chore/acceptance-refactor
jromero Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ make test

To run our full acceptance suite (including cross-compatibility for n-1 `pack` and `lifecycle`):
```shell
make acceptance-all
make compatibility
```

### Tidy
Expand Down
10 changes: 5 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ unit: out

acceptance: out
@echo "> Running acceptance tests..."
$(GOCMD) test $(GOTESTFLAGS) -timeout=$(ACCEPTANCE_TIMEOUT) -tags=acceptance ./acceptance
$(GOCMD) test $(GOTESTFLAGS) -timeout=$(ACCEPTANCE_TIMEOUT) -tags=acceptance ./acceptance/...

acceptance-all: export ACCEPTANCE_SUITE_CONFIG:=$(shell $(CAT) .$/acceptance$/testconfig$/all.json)
acceptance-all:
@echo "> Running acceptance tests..."
$(GOCMD) test $(GOTESTFLAGS) -timeout=$(ACCEPTANCE_TIMEOUT) -tags=acceptance ./acceptance
compatibility: export ACCEPTANCE_SUITE_CONFIG:=$(shell $(CAT) .$/acceptance$/testconfig$/all.json)
compatibility:
@echo "> Configured acceptance tests to test compatibility..."
make acceptance

clean:
@echo "> Cleaning workspace..."
Expand Down
Loading