-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Weval on WPT matrix #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think the CI failure is just a file copy/plumbing issue hopefully...
@cfallin there seem to be 4 missing / failing tests here, which might be worth looking into as possible Weval bugs. |
Seems to be in |
@guybedford I've been poking around the test failure and I'm a little lost -- I see
and indeed the argument to |
@cfallin that is an expected failure - the case here is specifically a panic for |
It appears to be an issue of memory size limits:
Now working out exactly where the limit is set and how to update this for the |
Actually, that appears to be an issue with an old Wasmtime (Zulip thread); upgrading my local Wasmtime and running locally, I am unable to reproduce when running just the one test:
but I see the failure when running the whole suite. I'm not sure where to go from here -- "event loop error - both task and job queues are empty, but expected operations did not resolve" does not tell me much, and without a single testcase I can try to reduce further I'm not really able to deduce anything. @guybedford are you by chance able to help derive a smaller testcase or do you have any ideas here? |
@cfallin I updated Wasmtime but that doesn't seem to be the issue. I was able to verify again it is definitely the headers test though. Happy to run through it with you further when you have a moment. |
This extends Weval into the WPT CI matrix, also adding it into a matrix for the main test run as well.