Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Weval on WPT matrix #114

Merged
merged 11 commits into from
Oct 11, 2024
Merged

ci: Weval on WPT matrix #114

merged 11 commits into from
Oct 11, 2024

Conversation

guybedford
Copy link
Contributor

This extends Weval into the WPT CI matrix, also adding it into a matrix for the main test run as well.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think the CI failure is just a file copy/plumbing issue hopefully...

.github/workflows/main.yml Outdated Show resolved Hide resolved
@guybedford
Copy link
Contributor Author

@cfallin there seem to be 4 missing / failing tests here, which might be worth looking into as possible Weval bugs.

@guybedford
Copy link
Contributor Author

Seems to be in fetch/api/headers/header-values.any.js.

@cfallin
Copy link
Member

cfallin commented Aug 19, 2024

@guybedford I've been poking around the test failure and I'm a little lost -- I see

Error running file html/webappapis/timers/evil-spec-example.any.js: setTimeout: first argument must be a function

and indeed the argument to setTimeout (line 9 of that file) is not a function, so the error should be expected? Perhaps it's an issue with the expected error message but I'm not able to find where that is tested; any help appreciated!

@guybedford
Copy link
Contributor Author

@cfallin that is an expected failure - the case here is specifically a panic for header-values.any.js resulting in the log MISSING TEST.... I can help dig into this further if you need.

@cfallin
Copy link
Member

cfallin commented Aug 20, 2024

It appears to be an issue of memory size limits:

wasmtime stderr: Error: memory index 0 has a minimum page size of 165 which exceeds the limit of 160

Now working out exactly where the limit is set and how to update this for the wasmtime serve command we run for WPT.

@cfallin
Copy link
Member

cfallin commented Aug 20, 2024

Actually, that appears to be an issue with an old Wasmtime (Zulip thread); upgrading my local Wasmtime and running locally, I am unable to reproduce when running just the one test:

% node tests/wpt-harness/run-wpt.mjs -vv header-values.any.js
Starting WPT server (cmd: /home/cfallin/work/starlingmonkey/tests/wpt-harness/wpt/wpt --no-h2 serve)...
Starting Wasmtime server (cmd: wasmtime serve -W max-memory-size=134217728 -S common --addr 127.0.0.1:7676 wpt-runtime.wasm)...
wasmtime stderr: Serving HTTP on http://127.0.0.1:7676/
[ ... ]
fetch/api/headers/header-values.any.js    3 /    4 (   +0,    -0,    ?0) passing in    0ms

Done. Stats:                              3 /    4 (   +0,    -0,    ?0) passing in    0ms

but I see the failure when running the whole suite. I'm not sure where to go from here -- "event loop error - both task and job queues are empty, but expected operations did not resolve" does not tell me much, and without a single testcase I can try to reduce further I'm not really able to deduce anything. @guybedford are you by chance able to help derive a smaller testcase or do you have any ideas here?

@guybedford
Copy link
Contributor Author

@cfallin I updated Wasmtime but that doesn't seem to be the issue. I was able to verify again it is definitely the headers test though. Happy to run through it with you further when you have a moment.

@guybedford guybedford merged commit 150501f into main Oct 11, 2024
5 checks passed
@guybedford guybedford deleted the weval-matrix branch October 11, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants