-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 21 product showcase #86
Conversation
Looks cool :) Adjusted a few requirements:
Additionally:
Examples: |
Oh i misunderstood the logo, thank for clarifying :) |
There is a design decision, and I'm curious about your opinion: We have fix grid element width as you can see above, and the second: Where we always fill the width of the container, no matter there is one grid element in the row or four. |
Looks great! Few comments regarding display:
I like the decision to match the height of the boxes to the biggest text. Created a follow-up for that: #88 (but don't worry about it for now). |
Btw, sorry for not reviewing the last few PRs, I was unsubscribed from the notifications for some reason. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left two comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix Zsolt's outstanding comment, otherwise approved from my side.
Issue #21
This section is to showcase products that are not open source or have a bigger scope so they cannot be showcased as git repositories.
Changes:
Visual: