Trim down Config and Manager classes to remove unused behavior #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove factory methods that we won't be using as configuration is generated from cli options like source/plugin/connection now.
this extension isn't used any more.
Remove more functionality that we won't be using in migrations.
Without multiple environments, manager gets a bit simpler too.
We won't need these as each Config and Manager instance is attached to a single connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove many methods from
ConfigandManageras migrations will only need to operate on a single connection at a time. We no longer need multiple environments or several other features like aliases. This allows for several parameters to be removed and tests to be simpler.Part of #647