-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim down Config and Manager classes to remove unused behavior #689
Merged
Commits on Feb 11, 2024
-
Trim out datadomain, namespace and token replacement methods
Also remove factory methods that we won't be using as configuration is generated from cli options like source/plugin/connection now.
Configuration menu - View commit details
-
Copy full SHA for e1827e2 - Browse repository at this point
Copy the full SHA e1827e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c69daa - Browse repository at this point
Copy the full SHA 3c69daaView commit details
Commits on Feb 12, 2024
-
Remove more functionality that we won't be using in migrations.
Configuration menu - View commit details
-
Copy full SHA for 45e391f - Browse repository at this point
Copy the full SHA 45e391fView commit details -
Update manager for singular environment
Without multiple environments, manager gets a bit simpler too.
Configuration menu - View commit details
-
Copy full SHA for 9c5de38 - Browse repository at this point
Copy the full SHA 9c5de38View commit details -
Remove environment parameters from methods
We won't need these as each Config and Manager instance is attached to a single connection.
Configuration menu - View commit details
-
Copy full SHA for b431d95 - Browse repository at this point
Copy the full SHA b431d95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40c064c - Browse repository at this point
Copy the full SHA 40c064cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14e4dbc - Browse repository at this point
Copy the full SHA 14e4dbcView commit details
Commits on Feb 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a98164b - Browse repository at this point
Copy the full SHA a98164bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6068756 - Browse repository at this point
Copy the full SHA 6068756View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.