Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(23.10): add archive for curl and its dependencies #127

Closed
wants to merge 14 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 9, 2024

No description provided.

@ghost ghost marked this pull request as ready for review February 14, 2024 10:57
@ghost
Copy link
Author

ghost commented Feb 20, 2024

@cjdcordeiro gentle review reminder!

@ghost
Copy link
Author

ghost commented Feb 20, 2024

@cjdcordeiro Do you see a point in a tool like this?

image

@cjdcordeiro
Copy link
Collaborator

@cjdcordeiro Do you see a point in a tool like this?

image

this is interesting @yashashwi :)

We'll be working, in the future, on expanding chisel to have additional tooling to help both the inspection and creation of slices. The slice inspection and discoverability features are already being proposed in canonical/chisel#99 and canonical/chisel#101.

The assisted creation of slices shall come later, but it is extremely refreshing to see the community coming up with their own solutions :)

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Just a few nitpicks and a leftover SDF to fix

slices/libldap-2.5-0.yaml Outdated Show resolved Hide resolved
slices/libgpg-error0.yaml Outdated Show resolved Hide resolved
slices/libssh2-1.yaml Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Feb 22, 2024

@cjdcordeiro Fixed review comments.

@ghost ghost requested a review from cjdcordeiro February 23, 2024 11:46
@ghost
Copy link
Author

ghost commented Feb 26, 2024

@cjdcordeiro review pending.

Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated already

@ghost
Copy link
Author

ghost commented Feb 27, 2024

@rebornplusplus could you please review this.

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one dependency seems to be wrong. Everything else looks very good. Thank you!

slices/libssh2-1.yaml Outdated Show resolved Hide resolved
removed incorrect dependency

Co-authored-by: Rafid Bin Mostofa <[email protected]>
@ghost
Copy link
Author

ghost commented Feb 28, 2024

@rebornplusplus fixed.

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ghost
Copy link
Author

ghost commented Mar 1, 2024

@cjdcordeiro review pending.

@ghost
Copy link
Author

ghost commented Mar 5, 2024

@cjdcordeiro could you please review this PR.
FYI, I have signed CLA, now if you run the CI-checks, it should pass.

@cjdcordeiro
Copy link
Collaborator

Hi @yashashwi

apologies for the delay but we've been working on some high priority CI checks that are a must for all the pending PRs.
In the meantime, I've re-run the CLA check and it is still failing. It appears there are multiple authors in your commits, including a local user

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing CLA check

@ghost
Copy link
Author

ghost commented Mar 6, 2024

failing CLA check

Yeah some of the initial commits have been as the root user. It seems I have to recommit all of it and re raise the PR.

Np! I understand you are occupied.

@linostar
Copy link
Collaborator

Closed in favor of #186

@linostar linostar closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants