Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(23.10):add archive for curl in mantic #186

Merged
merged 8 commits into from
May 24, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 8, 2024

# Proposed changes
Adding archive for CURL and its transitive dependencies

This PR is same as #127 but with CLA approved.
This change is already available in 22.04 and 24.04

Copy link

Diff of dependencies:

slices/libbrotli1.yaml
@@ -1 +0,0 @@
-libc6
slices/libgnutls30.yaml
@@ -1,8 +0,0 @@
-libc6
-libgmp10
-libhogweed6
-libidn2-0
-libnettle8
-libp11-kit0
-libtasn1-6
-libunistring2
slices/libhogweed6.yaml
@@ -1,3 +0,0 @@
-libc6
-libgmp10
-libnettle8

Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

slices/libldap2.yaml Outdated Show resolved Hide resolved
@cjdcordeiro cjdcordeiro requested a review from linostar May 16, 2024 10:34
@cjdcordeiro cjdcordeiro self-assigned this May 16, 2024
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty. will wait for @rebornplusplus 's review and then merge

Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@cjdcordeiro cjdcordeiro merged commit 641fcd3 into canonical:ubuntu-23.10 May 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants