Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use updated scripts for PRs to main #145

Merged

Conversation

rebornplusplus
Copy link
Member

Whenever there is a PR to the main branch, the scripts may be updated. Use the updated changes from the head_ref in the CI, to run the installability tests.

@rebornplusplus rebornplusplus force-pushed the ci/install-slices/use-updates branch 3 times, most recently from 5a801b6 to f385e9f Compare February 23, 2024 05:44
@rebornplusplus rebornplusplus marked this pull request as ready for review February 23, 2024 05:45
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should discuss this offline. the execution of external workflows could have a security impact

@rebornplusplus rebornplusplus added the Blocked Waiting for something external label Feb 27, 2024
@cjdcordeiro cjdcordeiro self-assigned this Mar 7, 2024
@cjdcordeiro cjdcordeiro removed the Blocked Waiting for something external label Mar 7, 2024
Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job.

@cjdcordeiro cjdcordeiro merged commit f6324cc into canonical:main Mar 7, 2024
30 checks passed
gregory-schiano pushed a commit to gregory-schiano/chisel-releases that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants