Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): add lint workflows and configs #146

Merged
merged 8 commits into from
Mar 6, 2024

Conversation

rebornplusplus
Copy link
Member

@rebornplusplus rebornplusplus commented Feb 23, 2024

This PR adds a linting workflow file and yamllint configurations.


PR run: https://github.com/rebornplusplus/chisel-releases/actions/runs/8140655095?pr=6

Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

.github/scripts/lint/lint.py Outdated Show resolved Hide resolved
@cjdcordeiro cjdcordeiro self-assigned this Feb 29, 2024
@rebornplusplus rebornplusplus changed the title chore(main): add lint workflows, configs and scripts chore(main): add lint workflows and configs Mar 4, 2024
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! thanks. some nitpicks and should be ready

.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
+1 for making this a reusable workflow as it used elsewhere too.

pip is already installed in GitHub runners.
yq is already installed in GitHub runners.
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing. I think https://github.com/canonical/chisel-releases/pull/146/files#diff-4b122024a3a28ded65da76a2f1bface1f3a27328374438d1298d25585fe0603bR58 should probably not reference the main and just be "this" branch instead.

@rebornplusplus
Copy link
Member Author

CI is failing. I think https://github.com/canonical/chisel-releases/pull/146/files#diff-4b122024a3a28ded65da76a2f1bface1f3a27328374438d1298d25585fe0603bR58 should probably not reference the main and just be "this" branch instead.

Yeah CI will fail because we are not using the updated scripts introduced in the PR. This was proposed in #145.

@cjdcordeiro
Copy link
Collaborator

I think it's different from #145 in the sense that there's very little risk here since you're only using the yamllint configuration file.

In fact, even on #145 we should probably allow it

@rebornplusplus
Copy link
Member Author

Alright I have updated the PR to checkout head_ref for PRs to main, similar to #145. The linters are running now, but failing with lint rules.

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. thanks. merging but can u pls create an issue in the backlog to fix those yamls?

@cjdcordeiro cjdcordeiro merged commit 2d67110 into canonical:main Mar 6, 2024
31 of 35 checks passed
@rebornplusplus
Copy link
Member Author

Will do!

gregory-schiano pushed a commit to gregory-schiano/chisel-releases that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants