-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(main): add lint workflows and configs #146
Conversation
8864800
to
2678575
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! thanks. some nitpicks and should be ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
+1 for making this a reusable workflow as it used elsewhere too.
pip is already installed in GitHub runners.
yq is already installed in GitHub runners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing. I think https://github.com/canonical/chisel-releases/pull/146/files#diff-4b122024a3a28ded65da76a2f1bface1f3a27328374438d1298d25585fe0603bR58 should probably not reference the main
and just be "this" branch instead.
Yeah CI will fail because we are not using the updated scripts introduced in the PR. This was proposed in #145. |
Alright I have updated the PR to checkout head_ref for PRs to main, similar to #145. The linters are running now, but failing with lint rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. thanks. merging but can u pls create an issue in the backlog to fix those yamls?
Will do! |
--------- Co-authored-by: Cristovao Cordeiro <[email protected]>
This PR adds a linting workflow file and yamllint configurations.
PR run: https://github.com/rebornplusplus/chisel-releases/actions/runs/8140655095?pr=6