Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): add lint workflows and configs #146

Merged
merged 8 commits into from
Mar 6, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
name: Lint

on:
pull_request:
branches:
- "main"
paths:
- ".github/workflows/lint.yaml"
- ".github/yamllint.yaml"
schedule:
# Run at 00:00 every day.
# Ref: https://man7.org/linux/man-pages/man5/crontab.5.html
- cron: "0 0 * * *"
workflow_call:

env:
# chisel-releases branches to lint on.
RELEASES: ${{ toJson('["ubuntu-20.04","ubuntu-22.04","ubuntu-23.10","ubuntu-24.04"]') }}

jobs:
prepare-lint:
runs-on: ubuntu-latest
name: "Prepare to lint"
outputs:
matrix: ${{ steps.set-output.outputs.matrix }}
steps:
- name: Set output
id: set-output
run: |
set -ex

if [[
"${{ github.base_ref || github.ref_name }}" == "main" ||
"${{ github.event_name }}" == "schedule"
]]; then
echo "matrix={\"ref\":${{ env.RELEASES }}}" >> $GITHUB_OUTPUT
else
echo "matrix={\"ref\":[\"\"]}" >> $GITHUB_OUTPUT
fi
rebornplusplus marked this conversation as resolved.
Show resolved Hide resolved

lint:
runs-on: ubuntu-latest
name: "Lint"
needs: prepare-lint
strategy:
fail-fast: false
matrix: ${{ fromJson(needs.prepare-lint.outputs.matrix) }}
env:
main-branch-path: files-from-main
steps:
- uses: actions/checkout@v4
with:
ref: ${{ matrix.ref }}

- name: Checkout main branch
uses: actions/checkout@v4
with:
ref: main
path: ${{ env.main-branch-path }}

- name: Install dependencies
run: |
set -ex
pip install --upgrade pip
pip install yamllint

- name: Lint with yamllint
env:
config-path: "${{ env.main-branch-path }}/.github/yamllint.yaml"
run: |
set -e
yamllint -c "${{ env.config-path }}" \
chisel.yaml \
slices/

- name: Lint with SDF-specific rules
run: |
set -e

export LC_COLLATE=C
EXIT_CODE=0

err() {
echo "error: " "$@" >&2
EXIT_CODE=1
}
warn() {
echo "warning: " "$@" >&2
}

for filename in $(find slices/ | grep "\.yaml$" | sort); do
yq '.slices | keys | .[]' "$filename" | sort -C || \
warn "$filename: slice names are not sorted"
for slice in $(yq '.slices | keys | .[]' "$filename"); do
key="$slice" yq \
'.slices | with_entries(select(.key == env(key))) | .[].essential[]' \
"$filename" | sort -C || \
err "$filename: $slice: \"essential\" entries are not sorted"
key="$slice" yq \
'.slices | with_entries(select(.key == env(key))) | .[].contents | select(.) | keys | .[]' \
"$filename" | sort -C || \
err "$filename: $slice: \"contents\" entries are not sorted"
done
done

exit $EXIT_CODE
33 changes: 33 additions & 0 deletions .github/yamllint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# yamllint configurations.
# Ref: https://yamllint.readthedocs.io/en/stable/configuration.html

extends: default

# Ref: https://yamllint.readthedocs.io/en/stable/rules.html
rules:
braces:
forbid: false
min-spaces-inside: 0
max-spaces-inside: 1
min-spaces-inside-empty: 0
max-spaces-inside-empty: 0
brackets:
forbid: false
min-spaces-inside: 0
max-spaces-inside: 1
min-spaces-inside-empty: 0
max-spaces-inside-empty: 0
comments:
level: error
comments-indentation:
level: error
document-end:
present: false
document-start:
present: false
empty-lines:
max: 1
indentation:
spaces: 2
line-length:
max: 80
Loading