feat(24.04): add python3-pip slices #356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff of dependencies: slices/python3-pip.yaml@@ -1,4 +1,4 @@
ca-certificates
-python3
python3-setuptools
python3-wheel
+python3.12slices/python3-pkg-resources.yaml@@ -1 +0,0 @@
-python3slices/python3-setuptools.yaml@@ -1,2 +1 @@
-python3
python3-pkg-resourcesslices/python3-wheel.yaml@@ -1 +0,0 @@
-python3 |
rebornplusplus
force-pushed
the
feat/python3-pip
branch
from
085d712
to
f913ef5
Compare
cjdcordeiro
requested changes
Oct 2, 2024
This slice comes with python3.12 installed.
linostar
suggested changes
Oct 16, 2024
| rootfs="$(install-slices python3-pip_bins3-12)" | ||
|
|
||
| # pip depends on python3. | ||
| ln -s /usr/bin/python3.12 ${rootfs}/usr/bin/python3 |
There was a problem hiding this comment.
Suggested change
| ln -s /usr/bin/python3.12 ${rootfs}/usr/bin/python3 | |
| ln -s ${rootfs}/usr/bin/python3.12 ${rootfs}/usr/bin/python3 |
There was a problem hiding this comment.
This would not work, because when I run within chroot, it's going to look for python3 at ${rootfs}/usr/bin but there won't be any directory ${rootfs} within the chroot jail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
python3-pipslices and it's dependencies.