-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): add python3-pip slices #356
Open
rebornplusplus
wants to merge
4
commits into
canonical:ubuntu-24.04
Choose a base branch
from
rebornplusplus:feat/python3-pip
base: ubuntu-24.04
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f913ef5
feat(24.04): add pip slices
rebornplusplus 17fafc7
feat: add python3-pip_bins3-12 slice
rebornplusplus 0b0645f
Merge branch 'ubuntu-24.04' into feat/python3-pip
rebornplusplus f08f05f
Merge branch 'ubuntu-24.04' into feat/python3-pip
rebornplusplus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package: python3-pip | ||
|
|
||
| essential: | ||
| - python3-pip_copyright | ||
|
|
||
| slices: | ||
| bins: | ||
| # Although pip requires python3, python3.x slices are not listed as an | ||
| # essential here because we might choose to install python3-pip with | ||
| # different versions of python3. | ||
| # For pip with python3.12, please use the "bins3-12" slice. | ||
| essential: | ||
| - python3-pip_libs | ||
| contents: | ||
| /usr/bin/pip: | ||
| /usr/bin/pip3: | ||
|
|
||
| libs: | ||
| essential: | ||
| - ca-certificates_data | ||
| - python3-setuptools_libs | ||
| - python3-wheel_libs | ||
| contents: | ||
| /usr/lib/python3/dist-packages/pip-*.dist-info/**: | ||
| /usr/lib/python3/dist-packages/pip/**: | ||
|
|
||
| # pip binaries with python3.12. | ||
| bins3-12: | ||
| essential: | ||
| - python3-pip_bins | ||
| - python3.12_standard | ||
|
|
||
| copyright: | ||
| contents: | ||
| /usr/share/doc/python3-pip/copyright: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package: python3-pkg-resources | ||
|
|
||
| essential: | ||
| - python3-pkg-resources_copyright | ||
|
|
||
| slices: | ||
| libs: | ||
| # Although pkg-resources requires python3, python3.x slices are not listed | ||
| # as an essential here because we might choose to install | ||
| # python3-pkg-resources with different versions of python3. | ||
| contents: | ||
| /usr/lib/python3/dist-packages/pkg_resources/**: | ||
|
|
||
| copyright: | ||
| contents: | ||
| /usr/share/doc/python3-pkg-resources/copyright: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package: python3-setuptools | ||
|
|
||
| essential: | ||
| - python3-setuptools_copyright | ||
|
|
||
| slices: | ||
| libs: | ||
| # Although setuptools requires python3, python3.x slices are not listed as | ||
| # an essential here because we might choose to install python3-setuptools | ||
| # with different versions of python3. | ||
| essential: | ||
| - python3-pkg-resources_libs | ||
| contents: | ||
| /usr/lib/python3/dist-packages/_distutils_hack/**: | ||
| /usr/lib/python3/dist-packages/setuptools-*.egg-info/**: | ||
| /usr/lib/python3/dist-packages/setuptools/**: | ||
|
|
||
| copyright: | ||
| contents: | ||
| /usr/share/doc/python3-setuptools/copyright: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package: python3-wheel | ||
|
|
||
| essential: | ||
| - python3-wheel_copyright | ||
|
|
||
| slices: | ||
| libs: | ||
| # Although wheel requires python3, python3.x slices are not listed as an | ||
| # essential here because we might choose to install python3-wheel with | ||
| # different versions of python3. | ||
| contents: | ||
| /usr/lib/python3/dist-packages/wheel-*.dist-info/**: | ||
| /usr/lib/python3/dist-packages/wheel/**: | ||
|
|
||
| copyright: | ||
| contents: | ||
| /usr/share/doc/python3-wheel/copyright: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| summary: Integration tests for python3-pip | ||
|
|
||
| execute: | | ||
| rootfs="$(install-slices python3-pip_bins3-12)" | ||
| # pip depends on python3. | ||
| ln -s /usr/bin/python3.12 ${rootfs}/usr/bin/python3 | ||
| # Smoke tests. | ||
| chroot ${rootfs} /usr/bin/pip --version | ||
| chroot ${rootfs} /usr/bin/pip install --upgrade setuptools | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would not work, because when I run within
chroot, it's going to look forpython3at${rootfs}/usr/binbut there won't be any directory${rootfs}within thechrootjail.