build(deps): bump craft-archives #5124
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigarmo
force-pushed
the
work/CRAFT-3538-noble-key-conflict
branch
from
56a1ed5
to
c13c393
Compare
tigarmo
force-pushed
the
work/CRAFT-3538-noble-key-conflict
branch
2 times, most recently
from
afebe09
to
c136094
Compare
This update fixes LP#2083013, where some package-repositories declarations could conflict with default sources present in Noble and later.
tigarmo
force-pushed
the
work/CRAFT-3538-noble-key-conflict
branch
from
c136094
to
1c11c58
Compare
lengau
approved these changes
Oct 18, 2024
| @@ -25,7 +25,7 @@ codespell==2.3.0 | |||
| colorama==0.4.6 | |||
| coverage==7.6.1 | |||
| craft-application==4.2.7 | |||
| craft-archives==2.0.0 | |||
| craft-archives @ git+https://github.com/canonical/craft-archives@work/CRAFT-3538-noble-key-conflict | |||
There was a problem hiding this comment.
Just putting this here to make it easy if you take my suggestion about releasing today.
Suggested change
| craft-archives @ git+https://github.com/canonical/craft-archives@work/CRAFT-3538-noble-key-conflict | |
| craft-archives==2.0.1 |
| @@ -20,7 +20,7 @@ charset-normalizer==3.3.2 | |||
| click==8.1.7 | |||
| colorama==0.4.6 | |||
| craft-application==4.2.7 | |||
| craft-archives==2.0.0 | |||
| craft-archives @ git+https://github.com/canonical/craft-archives@work/CRAFT-3538-noble-key-conflict | |||
There was a problem hiding this comment.
Just putting this here to make it easy if you take my suggestion about releasing today.
Suggested change
| craft-archives @ git+https://github.com/canonical/craft-archives@work/CRAFT-3538-noble-key-conflict | |
| craft-archives==2.0.1 |
| @@ -8,7 +8,7 @@ chardet==5.2.0 | |||
| charset-normalizer==3.3.2 | |||
| click==8.1.7 | |||
| craft-application==4.2.7 | |||
| craft-archives==2.0.0 | |||
| craft-archives @ git+https://github.com/canonical/craft-archives@work/CRAFT-3538-noble-key-conflict | |||
There was a problem hiding this comment.
Just putting this here to make it easy if you take my suggestion about releasing today.
Suggested change
| craft-archives @ git+https://github.com/canonical/craft-archives@work/CRAFT-3538-noble-key-conflict | |
| craft-archives==2.0.1 |
| @@ -9,6 +9,7 @@ environment: | |||
| SNAP/test_multi_keys: test-multi-keys | |||
| SNAP/test_foreign_armhf: test-foreign-armhf | |||
| SNAP/test_foreign_i386: test-foreign-i386 | |||
| SNAP/test_key_conflict: test-key-conflict | |||
There was a problem hiding this comment.
This is an excellent example of well-designed tests sight here.
| @@ -0,0 +1,31 @@ | |||
| name: test-key-conflict | |||
| version: '1.0' | |||
| summary: test package repos with keys already present on the system | |||
There was a problem hiding this comment.
Like the well-designed tests above, this is a well-written example that makes it really clear. Thanks!
tests/spread/core24/package-repositories/test-key-conflict/snapcraft.yaml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes LP#2083013, where some package-repositories declarations could conflict with default sources present in Noble.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)