build(deps): bump craft-archives #5124
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -8,7 +8,7 @@ chardet==5.2.0 | |||||
| charset-normalizer==3.3.2 | ||||||
| click==8.1.7 | ||||||
| craft-application==4.2.7 | ||||||
| craft-archives @ git+https://github.com/canonical/craft-archives@work/CRAFT-3538-noble-key-conflict | ||||||
|
There was a problem hiding this comment. Just putting this here to make it easy if you take my suggestion about releasing today.
Suggested change
|
||||||
| craft-cli==2.7.0 | ||||||
| craft-grammar==2.0.1 | ||||||
| craft-parts==2.1.2 | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ environment: | |
| SNAP/test_multi_keys: test-multi-keys | ||
| SNAP/test_foreign_armhf: test-foreign-armhf | ||
| SNAP/test_foreign_i386: test-foreign-i386 | ||
| SNAP/test_key_conflict: test-key-conflict | ||
|
There was a problem hiding this comment. This is an excellent example of well-designed tests sight here. |
||
|
|
||
| prepare: | | ||
| # Remove the currently installed "gpg" and "dirmngr" packages to ensure that | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: test-key-conflict | ||
| version: '1.0' | ||
| summary: test package repos with keys already present on the system | ||
|
There was a problem hiding this comment. Like the well-designed tests above, this is a well-written example that makes it really clear. Thanks! |
||
| description: test package repos with keys already present on the system | ||
| confinement: strict | ||
| base: core24 | ||
| platforms: | ||
| amd64: | ||
|
|
||
| package-repositories: | ||
| # In core24 this pair of url + suite is already listed in | ||
| # /etc/apt/sources.list.d/ubuntu.sources. Add it here to make sure this setup | ||
| # is working. | ||
| - type: apt | ||
lengau marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| url: http://archive.ubuntu.com/ubuntu | ||
| suites: [noble] | ||
| components: [main, universe] | ||
| architectures: [i386] | ||
| key-id: F6ECB3762474EDA9D21B7022871920D1991BC93C | ||
| key-server: keyserver.ubuntu.com | ||
|
|
||
| parts: | ||
| mypart: | ||
| plugin: nil | ||
| stage-packages: | ||
| - zlib1g:i386 # To ensure the package-repo is setup correctly | ||
| - hello # there is no hello:i386 in the archives | ||
|
|
||
| apps: | ||
| test-key-conflict: | ||
| command: usr/bin/hello -g hello | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just putting this here to make it easy if you take my suggestion about releasing today.