Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source metadata for vceregen #3887

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Add source metadata for vceregen #3887

merged 6 commits into from
Oct 3, 2024

Conversation

aesharpe
Copy link
Member

Overview

Closes #3886

What did you change?

Adds source metadata for vceregen so it's ready to be ingested by the archiver.

@aesharpe aesharpe self-assigned this Sep 30, 2024
@aesharpe aesharpe added new-data Requests for integration of new data. vcerare Pertaining to Vibrant Clean Energy's Resource Adequacy Renewable Energy Power datasets metadata Anything having to do with the content, formatting, or storage of metadata. Mostly datapackages. zenodo Issues having to do with Zenodo data archiving and retrieval. labels Sep 30, 2024
Comment on lines 842 to 846
"Hourly, county-level renewable generation profiles in the continental "
"United States. Compiled by Vibrant Clean Energy based on outputs from the "
"NOAA HRRR weather model. Profiles are stated as a capacity factor (a "
"fraction of nameplate capacity) and exist for onshore wind, offshore "
"wind, and fixed-tilt solar generation types."
Copy link
Member Author

@aesharpe aesharpe Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Borrowed some language from the description of gridpathtoolkit.

src/pudl/metadata/sources.py Outdated Show resolved Hide resolved
src/pudl/metadata/sources.py Show resolved Hide resolved
src/pudl/metadata/sources.py Show resolved Hide resolved
@aesharpe aesharpe marked this pull request as ready for review September 30, 2024 22:09
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question for @zaneselvans about the licensing.

We might want to add the documentation PDFs somewhere - left some thoughts in the comments.

src/pudl/metadata/sources.py Outdated Show resolved Hide resolved
src/pudl/metadata/sources.py Show resolved Hide resolved
@e-belfer e-belfer self-requested a review October 2, 2024 20:10
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add VCE in the CONTRIBUTORS dictionary and make them the contributor of this dataset, as discussed in the comments. Also worth seeing if we can check in the key PDF into our data sources folder in Git.

Comment on lines +840 to +841
"path": "https://vibrantcleanenergy.com/wp-content/uploads/2020/08/VCE-Weather-Dataset-Overview_August2020.pdf",
"description": (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could make this a path to the internal file, but wasn't 100% sure how to do that.

@e-belfer e-belfer self-requested a review October 3, 2024 17:58
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@e-belfer e-belfer added this pull request to the merge queue Oct 3, 2024
Comment on lines +189 to +196
"vibrant-clean-energy": {
"title": "Vibrant Clean Energy",
"email": "[email protected]",
"path": "https://vibrantcleanenergy.com/",
"role": "author",
"zenodo_role": "producer",
"organization": "Vibrant Clean Energy",
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we've got an archiver that works for a private file handoff, it'd be good to re-archive the GridPath RA Toolkit data using it, and do something similar for attribution / licensing there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, though slightly tricky to refresh the metadata without new files but it can be done. Want to write up an issue so it doesn't get lost?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #3895

Merged via the queue into main with commit 2ce5d76 Oct 3, 2024
17 checks passed
@e-belfer e-belfer deleted the vceregen-metadata branch October 3, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata Anything having to do with the content, formatting, or storage of metadata. Mostly datapackages. new-data Requests for integration of new data. vcerare Pertaining to Vibrant Clean Energy's Resource Adequacy Renewable Energy Power datasets zenodo Issues having to do with Zenodo data archiving and retrieval.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add source metadata for vceregen data
3 participants