-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source metadata for vceregen
#3887
Conversation
src/pudl/metadata/sources.py
Outdated
"Hourly, county-level renewable generation profiles in the continental " | ||
"United States. Compiled by Vibrant Clean Energy based on outputs from the " | ||
"NOAA HRRR weather model. Profiles are stated as a capacity factor (a " | ||
"fraction of nameplate capacity) and exist for onshore wind, offshore " | ||
"wind, and fixed-tilt solar generation types." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Borrowed some language from the description of gridpathtoolkit
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question for @zaneselvans about the licensing.
We might want to add the documentation PDFs somewhere - left some thoughts in the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add VCE in the CONTRIBUTORS dictionary and make them the contributor of this dataset, as discussed in the comments. Also worth seeing if we can check in the key PDF into our data sources folder in Git.
"path": "https://vibrantcleanenergy.com/wp-content/uploads/2020/08/VCE-Weather-Dataset-Overview_August2020.pdf", | ||
"description": ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could make this a path to the internal file, but wasn't 100% sure how to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
"vibrant-clean-energy": { | ||
"title": "Vibrant Clean Energy", | ||
"email": "[email protected]", | ||
"path": "https://vibrantcleanenergy.com/", | ||
"role": "author", | ||
"zenodo_role": "producer", | ||
"organization": "Vibrant Clean Energy", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we've got an archiver that works for a private file handoff, it'd be good to re-archive the GridPath RA Toolkit data using it, and do something similar for attribution / licensing there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely, though slightly tricky to refresh the metadata without new files but it can be done. Want to write up an issue so it doesn't get lost?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #3895
Overview
Closes #3886
What did you change?
Adds source metadata for
vceregen
so it's ready to be ingested by the archiver.