Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update it.po #453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

albanobattistella
Copy link

No description provided.

Copy link
Collaborator

@gnome-mpv gnome-mpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few issues that needs to be addressed before merging. I have a couple suggestions in my review, but I don't know Italian so please check them carefully.


#: data/io.github.celluloid_player.Celluloid.appdata.xml.in:71
msgid ""
"Improve handling of --window-scale, --autofit, --autofit-larger, and "
"--autofit-smaller"
msgstr ""
msgstr "Migliora la gestione di --scala della finestra, --adattamento automatico, --autoadattamento-largezza e "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option names should not be translated.

Suggested change
msgstr "Migliora la gestione di --scala della finestra, --adattamento automatico, --autoadattamento-largezza e "
msgstr "Migliora la gestione di --window-scale, --autofit, --autofit-larger e "


#: data/io.github.celluloid_player.Celluloid.appdata.xml.in:71
msgid ""
"Improve handling of --window-scale, --autofit, --autofit-larger, and "
"--autofit-smaller"
msgstr ""
msgstr "Migliora la gestione di --scala della finestra, --adattamento automatico, --autoadattamento-largezza e "
"--autoadattamento-dimensione"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"--autoadattamento-dimensione"
"--autofit-smaller"


#: data/io.github.celluloid_player.Celluloid.appdata.xml.in:106
msgid "Handle property change events for fullscreen and window-scale"
msgstr ""
msgstr "Gestire gli eventi di modifica delle proprietà per lo schermo intero e la scala delle finestre"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property names (fullscreen and window-scale) should not be translated.

Suggested change
msgstr "Gestire gli eventi di modifica delle proprietà per lo schermo intero e la scala delle finestre"
msgstr "Gestire gli eventi di modifica delle proprietà per fullscreen e window-scale"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I daresay these terms should be put in quotes in English text to avoid ambiguity.


#. Translators: Search terms to find this application. Don't translate the
#. semicolons! The list MUST also end with a semicolon!
#: data/io.github.celluloid_player.Celluloid.desktop.in:16
msgid "Video;Movie;Film;Clip;Series;Player;DVD;TV;Disc;Album;Music;GNOME;mpv;"
msgstr ""
msgstr "Video, film, film, clip; Serie; Player, DVD, TV, Disco; Album; Musica; GNOME; mpv;"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only semicolons should be used to separate entries. Also, there's no need to list identical entries twice.

Suggested change
msgstr "Video, film, film, clip; Serie; Player, DVD, TV, Disco; Album; Musica; GNOME; mpv;"
msgstr "Video;film;clip;Serie;Player;DVD;TV;Disco;Album;Musica;GNOME;mpv;"


#: src/celluloid-application.c:505
msgid "Set the window role"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be removed.


#: src/celluloid-application.c:505
msgid "Set the window role"
msgstr ""
msgid "Video;Movie;Film;Clip;Series;Player;DVD;TV;Disc;Album;Music;GNOME;mpv;"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be added; there's already an entry for it above.

@@ -914,4 +916,4 @@ msgstr "Un frontend in GTK+ per MPV"

#: src/celluloid-view.c:1349
msgid "translator-credits"
msgstr "Luca Trevisani"
msgstr "Albano Battistella"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't remove previous translator's name. Just add your name below.

Suggested change
msgstr "Albano Battistella"
msgstr "Luca Trevisani\n"
"Albano Battistella"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants