Tag container images when a tag is pushed to the repo #115
Conversation
🦋 Changeset detectedLatest commit: 4fe000c The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -42,3 +44,17 @@ jobs: | |||
| context: . | |||
| file: dockerfiles/phone-number-privacy/Dockerfile-combiner | |||
| trivy: true | |||
|
|
|||
| odis-combiner-tag: | |||
| uses: celo-org/reusable-workflows/.github/workflows/[email protected] | |||
There was a problem hiding this comment.
Have you try with main version?
We can make a tag there to be easier to use.
| @@ -42,3 +44,17 @@ | |||
| context: . | |||
| file: dockerfiles/phone-number-privacy/Dockerfile-loadtest | |||
| trivy: true | |||
|
|
|||
| odis-loadtest-tag: | |||
| uses: celo-org/reusable-workflows/.github/workflows/[email protected] | |||
There was a problem hiding this comment.
Same as previous.
Also why different versions here?
There was a problem hiding this comment.
Testing latest commit here. BTW the platforms default doesn't seem to work
There was a problem hiding this comment.
Should we use ' instead of "???
Description
This PR will add tags to the Docker containers in Artifact Registry for the ODIS artifacts when a tag is pushed to the repo so that we don't have to tag the images manually (
odis-combiner-.*for Combiner,odis-loadtest-.*for load tests,odis-signer-.*for Signer).Draft as it requires this PR in infra repo.
Other changes
Describe any minor or "drive-by" changes here.
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
Related issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.
Documentation
The set of community facing docs that have been added/modified because of this change