Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag container images when a tag is pushed to the repo #115

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/three-snakes-sing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
16 changes: 16 additions & 0 deletions .github/workflows/odis-combiner-container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ on:
- 'packages/phone-number-privacy/combiner/**'
branches:
- main
tags:
- odis-combiner-.*
pull_request:
paths:
- 'dockerfiles/phone-number-privacy/Dockerfile-combiner'
Expand Down Expand Up @@ -42,3 +44,17 @@ jobs:
context: .
file: dockerfiles/phone-number-privacy/Dockerfile-combiner
trivy: true

odis-combiner-tag:
uses: celo-org/reusable-workflows/.github/workflows/[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you try with main version?

We can make a tag there to be easier to use.

name: Build us-west1-docker.pkg.dev/devopsre/social-connect/odis-combiner
if: |
startsWith(github.ref, 'refs/tags/odis-combiner-')
with:
workload-id-provider: projects/1094498259535/locations/global/workloadIdentityPools/gh-social-connect-tag/providers/github-by-repos
service-account: '[email protected]'
artifact-registry: us-west1-docker.pkg.dev/devopsre/social-connect/odis-combiner
tag: ${{ github.ref_name }}
context: .
file: dockerfiles/phone-number-privacy/Dockerfile-combiner
trivy: true
16 changes: 16 additions & 0 deletions .github/workflows/odis-loadtest-container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
- 'packages/phone-number-privacy/monitor/**'
branches:
- main
tags:
- odis-loadtest-.*
pull_request:
paths:
- 'dockerfiles/phone-number-privacy/Dockerfile-loadtest'
Expand Down Expand Up @@ -42,3 +44,17 @@
context: .
file: dockerfiles/phone-number-privacy/Dockerfile-loadtest
trivy: true

odis-loadtest-tag:
uses: celo-org/reusable-workflows/.github/workflows/[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous.
Also why different versions here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing latest commit here. BTW the platforms default doesn't seem to work

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use ' instead of "???

name: Build us-west1-docker.pkg.dev/devopsre/social-connect/odis-loadtest
if: |
startsWith(github.ref, 'refs/tags/odis-loadtest-')
with:
workload-id-provider: projects/1094498259535/locations/global/workloadIdentityPools/gh-social-connect-tag/providers/github-by-repos
service-account: '[email protected]'
artifact-registry: us-west1-docker.pkg.dev/devopsre/social-connect/odis-loadtest
tag: ${{ github.ref_name }}
context: .
file: dockerfiles/phone-number-privacy/Dockerfile-loadtest
trivy: true
16 changes: 16 additions & 0 deletions .github/workflows/odis-signer-container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
- 'packages/phone-number-privacy/signer/**'
branches:
- main
tags:
- odis-signer-.*
pull_request:
paths:
- 'dockerfiles/phone-number-privacy/Dockerfile-signer'
Expand Down Expand Up @@ -42,3 +44,17 @@
context: .
file: dockerfiles/phone-number-privacy/Dockerfile-signer
trivy: true

odis-signer-tag:
uses: celo-org/reusable-workflows/.github/workflows/[email protected]
name: Build us-west1-docker.pkg.dev/devopsre/social-connect/odis-signer
if: |
startsWith(github.ref, 'refs/tags/odis-signer-')
with:
workload-id-provider: projects/1094498259535/locations/global/workloadIdentityPools/gh-social-connect-tag/providers/github-by-repos
service-account: '[email protected]'
artifact-registry: us-west1-docker.pkg.dev/devopsre/social-connect/odis-signer
tag: ${{ github.ref_name }}
context: .
file: dockerfiles/phone-number-privacy/Dockerfile-signer
trivy: true
Loading