Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to yarn4+ ditch Lerna #73

Merged
merged 69 commits into from
Oct 27, 2023
Merged

Upgrade to yarn4+ ditch Lerna #73

merged 69 commits into from
Oct 27, 2023

Conversation

aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Oct 5, 2023

Description

migrate to yarn berry aka yarn 3

replace lerna with yarn workspaces

demo: use yarn contraints to ensure engines field for all packages is node 18

Other changes

  • fixed one or two phantom deps
  • include example as a first class workspace
  • add dev setup to contributing guide
  • update info on releasing

Tested

test pass on my machine

Related issues

Backwards compatibility

yes as this way of using yarn3 keeps node_modules

Documentation

workflows should remain the same

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

🦋 Changeset detected

Latest commit: b211968

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
odis-example-scripts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security
Copy link

socket-security bot commented Oct 5, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@celo/wallet-local 5.1.0 None +78 7.33 MB aaron-clabs
@celo/utils 5.0.5 None +24 4.16 MB aaron-clabs
@celo/connect 5.1.0 None +46 4.39 MB aaron-clabs
@opentelemetry/auto-instrumentations-node 0.39.4 None +178 42.9 MB dyladan
@opentelemetry/api 1.6.0 None +0 780 kB pichlermarc
@opentelemetry/instrumentation 0.44.0 None +12 3.63 MB pichlermarc
@opentelemetry/sdk-metrics 1.17.1 None +4 5.01 MB pichlermarc
@opentelemetry/sdk-node 0.44.0 None +54 34.5 MB pichlermarc
@opentelemetry/exporter-jaeger 1.17.1 None +6 3.97 MB pichlermarc
@opentelemetry/sdk-trace-node 1.17.1 None +8 2.16 MB pichlermarc
@celo/contractkit 5.1.0 None +81 8.95 MB aaron-clabs
jest 29.5.0...29.7.0 None +476/-105 38.7 MB simenb
jest-snapshot 29.5.0...29.7.0 None +19/-54 2.83 MB simenb
@types/elliptic 6.4.14...6.4.16 None +3/-0 53 kB types
@types/express 4.17.17...4.17.18 None +36/-28 411 kB types
babel-jest 29.5.0...29.7.0 None +24/-52 2.9 MB simenb
@babel/core 7.21.4...7.23.2 None +5/-29 2.19 MB nicolo-ribaudo
@babel/runtime 7.21.0...7.23.2 None +1/-0 275 kB nicolo-ribaudo
@typescript-eslint/eslint-plugin 6.7.4...6.9.0 None +14/-15 5.31 MB jameshenry
@typescript-eslint/parser 6.7.4...6.9.0 None +9/-10 2.42 MB jameshenry
@types/jest 29.5.4...29.5.6 None +6/-13 173 kB types
jest-circus 29.5.0...29.7.0 None +40/-77 3.79 MB simenb
@types/debug 4.1.7...4.1.10 None +3/-2 16.1 kB types
bignumber.js 9.0.0...9.1.2 None +0/-0 351 kB mikemcl
eslint-plugin-prettier 5.0.0...5.0.1 None +5/-4 1.13 MB jounqin

🚮 Removed packages: [email protected], [email protected], [email protected], [email protected]

@aaronmgdr aaronmgdr changed the title DEMO : upgrade to yarn3 Upgrade to yarn3 + ditch Lerna Oct 13, 2023
# Conflicts:
#	.changeset/gorgeous-bananas-lick.md
#	packages/phone-number-privacy/combiner/package.json
#	yarn.lock
@aaronmgdr aaronmgdr mentioned this pull request Oct 24, 2023
@aaronmgdr aaronmgdr requested review from alecps, alvarof2 and soloseng and removed request for alecps and soloseng October 25, 2023 15:15
@nicolasbrugneaux
Copy link
Contributor

🥳

@aaronmgdr aaronmgdr changed the title Upgrade to yarn3 + ditch Lerna Upgrade to yarn4+ ditch Lerna Oct 26, 2023
RELEASE.md Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Collaborator

@alecps alecps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeeet!

@aaronmgdr aaronmgdr merged commit be529d4 into main Oct 27, 2023
13 checks passed
@aaronmgdr aaronmgdr deleted the chore/yarn3 branch October 27, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants