-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to yarn4+ ditch Lerna #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b211968 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…the package specifies to do so
# Conflicts: # packages/phone-number-privacy/combiner/package.json # yarn.lock
# Conflicts: # .changeset/gorgeous-bananas-lick.md # packages/phone-number-privacy/combiner/package.json # yarn.lock
Closed
🥳 |
try out not requiring cs when only md files changed
aaronmgdr
changed the title
Upgrade to yarn3 + ditch Lerna
Upgrade to yarn4+ ditch Lerna
Oct 26, 2023
alecps
reviewed
Oct 26, 2023
alecps
reviewed
Oct 26, 2023
alecps
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweeeeet!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
migrate to yarn berry aka yarn 3
replace lerna with yarn workspaces
demo: use yarn contraints to ensure engines field for all packages is node 18
Other changes
Tested
test pass on my machine
Related issues
Backwards compatibility
yes as this way of using yarn3 keeps node_modules
Documentation
workflows should remain the same