scrape button added #88

hkaur008 · 2021-10-13T03:43:22Z

Fixes: https://tracker.ceph.com/issues/53048

Scrape button added #83
Signed-off-by: Hargun Kaur [email protected]

Checklist

References tracker ticket
Updates documentation if necessary
Includes tests for new functionality or reproducer for bug

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox

hkaur008 · 2021-10-14T00:45:06Z

@ideepika can you check?

ideepika · 2021-10-14T10:59:44Z

pulpito/templates/run.html

@@ -80,6 +80,8 @@ <h2>
            </div>
            <button type="button" class="btn btn-info {{ '' if run.results.fail or run.results.dead else 'disabled'}}" id="expand-fail-btn"></button>
            <button type="button" class="btn btn-info" id="expand-desc-btn"></button>
+            <button type="button" class="btn btn-info" id="scrape" onclick="window.location.href='http://qa-proxy.ceph.com/teuthology/yuriw-2021-03-23_21:23:36-rados-wip-yuri7-testing-2021-03-23-1015-nautilus-distro-basic-smithi/scrape.log'">Scrape</button>


@hkaur008 the url I passed was an example and what I was intending to say that we need to url link based on
the job for pulpito examination please inspect https://pulpito.ceph.com developer tools and see Log file,

you can achieve something like that using scrape_log = "http://qa-proxy.ceph.com/{{ run.name }}/scrape.log"

Hm... I don't think the link to scrap should be as button close to the ones which intended to manipulate the list of jobs in a run.

@kshtsk should public/js/main.js be the right place then?

why main.js? maybe try to place this file before or after 'See detail view'? also draw it if there is no run.results.running and no run.results.queued, but I am not sure

I would generalize the link further, something to this effect: http://qa-proxy.ceph.com/{{ run.name }}".

That link would lead you to something like this:

Index of /teuthology/yuriw-2021-09-16_18:23:18-rados-wip-yuri2-testing-2021-09-16-0923-distro-basic-smithi/ ../ 6393441/ 16-Sep-2021 22:03 - 6393468/ 16-Sep-2021 22:24 - 6393474/ 17-Oct-2021 00:16 - 6393494/ 16-Sep-2021 22:45 - 6393507/ 17-Oct-2021 00:16 - 6393519/ 17-Oct-2021 00:16 - 6393526/ 16-Sep-2021 23:00 - 6393541/ 17-Oct-2021 00:16 - 6393548/ 16-Sep-2021 23:13 - 6393575/ 16-Sep-2021 23:26 - 6393603/ 16-Sep-2021 23:38 - 6393606/ 17-Oct-2021 00:16 - 6393628/ 16-Sep-2021 23:48 - 6393682/ 17-Sep-2021 00:21 - 6393702/ 18-Oct-2021 00:16 - 6393707/ 18-Oct-2021 00:16 - 6393708/ 17-Sep-2021 00:31 - 6393734/ 17-Sep-2021 00:44 - 6393748/ 18-Oct-2021 00:17 - 6393760/ 17-Sep-2021 00:57 - 6393788/ 17-Sep-2021 01:08 - 6393797/ 18-Oct-2021 00:16 - results.log 17-Sep-2021 05:05 146241 scrape.log 17-Sep-2021 05:05 3509

That way, someone could access the scrape log in addition to information about other jobs and the results.log. Like @kshtsk said, you could then place this link under "See detail view".

soo i just need to add the scrape.log link before the See detail view and that link would be like http://qa-proxy.ceph.com/{{ run.name }}/scrape.log

Okay Got it replaced with a generalised link rather than scrape.log

hkaur008 · 2021-10-14T12:08:33Z

Cool

…

On Thu, 14 Oct, 2021, 4:29 PM Deepika Upadhyay, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pulpito/templates/run.html <#88 (comment)>: > @@ -80,6 +80,8 @@ <h2> </div> <button type="button" class="btn btn-info {{ '' if run.results.fail or run.results.dead else 'disabled'}}" id="expand-fail-btn"></button> <button type="button" class="btn btn-info" id="expand-desc-btn"></button> + <button type="button" class="btn btn-info" id="scrape" onclick="window.location.href='http://qa-proxy.ceph.com/teuthology/yuriw-2021-03-23_21:23:36-rados-wip-yuri7-testing-2021-03-23-1015-nautilus-distro-basic-smithi/scrape.log'">Scrape</button> @hkaur008 <https://github.com/hkaur008> the url I passed was an example and what I was intending to say that we need to url link based on the job for pulpito examination please inspect https://pulpito.ceph.com developer tools and see Log file, job.log_href looks like: http://qa-proxy.ceph.com/teuthology/ideepika-2021-10-14_07:14:29-rbd:iscsi-wip-nizamial09-testing-2021-10-11-1540-distro-default-smithi/6442773/teuthology.log you can achieve something like that using scrape_log = " http://qa-proxy.ceph.com/{{ job['name'] }}/scrape.log" place to look at: pulpito/templates/run_jobs_table.html — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#88 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANOWNVAOO6PJKVCCZEEY6JDUG2Z2XANCNFSM5F4FMOTA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

kshtsk · 2021-10-14T12:40:26Z

If scrape is something that runs at the end of the whole run finished, maybe make the link visible when the scrape output close to be available, I mean not from the very begging of job.

That does not neglect that it should not be a button from job list filter group, maybe just another reference above the list?

ideepika · 2021-10-19T06:34:56Z

@hkaur008 let us know if you need any help, thanks!

ljflores · 2021-10-26T17:22:38Z

I created a Tracker associated with this PR: https://tracker.ceph.com/issues/53048. @hkaur008 would you please add this to your PR description and to your commit?

You can edit your PR description by clicking the three dots next to the emoticon and clicking "Edit."
You can edit your commit by typing git commit --amend in your terminal and following the prompts.
Add this line to both: Fixes: https://tracker.ceph.com/issues/53048.

Let us know if you need any help!

hkaur008 · 2021-10-26T18:15:43Z

Sure

…

On Tue, 26 Oct, 2021, 10:52 PM Laura Flores, ***@***.***> wrote: I created a Tracker associated with this PR: https://tracker.ceph.com/issues/53048. @hkaur008 <https://github.com/hkaur008> would you please add this to your PR description and to your commit? You can edit your PR description by clicking the three dots next to the emoticon and clicking "Edit." You can edit your commit by typing git commit --amend in your terminal and following the prompts. Add this line to both: Fixes: https://tracker.ceph.com/issues/53048. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANOWNVAXCBY7VXDUTSIKUJTUI3PWTANCNFSM5F4FMOTA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

hkaur008 · 2021-12-23T14:00:05Z

Sorry, I got busy with my exams will start working on this pull request again!

hkaur008 · 2021-12-23T14:14:08Z

Whenever i try to run it I get in this error , any leads would be helpful

hkaur008 · 2021-12-23T14:31:35Z

@ljflores I have added the code, Can you have a look? If things are okay!

ljflores · 2022-01-03T22:44:58Z

Thanks @hkaur008! I'll see if @kamoltat can take a look.

hkaur008 · 2022-01-04T04:43:39Z

Cool

…

On Tue, 4 Jan, 2022, 4:15 AM Laura Flores, ***@***.***> wrote: Thanks @hkaur008 <https://github.com/hkaur008>! I'll see if @kamoltat <https://github.com/kamoltat> can take a look. — Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANOWNVG3WGSO6NMH4RC3OLDUUIRHNANCNFSM5F4FMOTA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

kamoltat

@hkaur008 Just some changes, other than that it looks great! Thanks for doing this. Lastly, please squash your commit into 1 commit. Let me know if you need help doing this.

kamoltat · 2022-01-14T15:40:47Z

pulpito/templates/run.html

+              <h2>
+                <a href="http://qa-proxy.ceph.com/{{ run.name }}"> Want to see scrape.log?</a>
+              </h2>


Should be

Suggested change

<h2>

<a href="http://qa-proxy.ceph.com/{{ run.name }}"> Want to see scrape.log?</a>

</h2>

<h2>

<a href="http://qa-proxy.ceph.com/teuthology/{{ run.name }}/scrape.log"> Want to see scrape.log?</a>

</h2>

sure ! i check

@hkaur008 @kamoltat any updates regarding that PR?

scrape button added

b836b89

ideepika reviewed Oct 14, 2021

View reviewed changes

hkaur008 added 3 commits December 23, 2021 19:19

Merge branch 'ceph:master' into master

fa89f1d

Fixes: https://tracker.ceph.com/issues/53048

93c6767

Merge branch 'master' of https://github.com/hkaur008/pulpito

053b45b

hkaur008 added 3 commits December 23, 2021 14:27

scrape log added

4d2b8c6

scrape log added

03a8ef6

removing paragraphs

1c01b66

hkaur008 requested review from ljflores and ideepika December 23, 2021 14:31

replacing with generalised link

cba28cf

ljflores requested a review from kamoltat January 3, 2022 22:45

kamoltat requested changes Jan 14, 2022

View reviewed changes

djgalloway changed the base branch from master to main June 1, 2022 17:04

Adityaakr mentioned this pull request Sep 13, 2023

Scrape button Added #96

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scrape button added #88

scrape button added #88

hkaur008 commented Oct 13, 2021 •

edited

Loading

hkaur008 commented Oct 14, 2021

ideepika Oct 14, 2021 •

edited

Loading

kshtsk Oct 14, 2021

ideepika Oct 14, 2021

kshtsk Oct 14, 2021

ljflores Oct 26, 2021 •

edited

Loading

hkaur008 Dec 23, 2021

hkaur008 Dec 23, 2021

hkaur008 commented Oct 14, 2021 via email

kshtsk commented Oct 14, 2021

ideepika commented Oct 19, 2021

ljflores commented Oct 26, 2021 •

edited

Loading

hkaur008 commented Oct 26, 2021 via email

hkaur008 commented Dec 23, 2021 •

edited

Loading

hkaur008 commented Dec 23, 2021

hkaur008 commented Dec 23, 2021

ljflores commented Jan 3, 2022

hkaur008 commented Jan 4, 2022 via email

kamoltat left a comment •

edited

Loading

kamoltat Jan 14, 2022

hkaur008 Apr 19, 2022

NitzanMordhai Feb 5, 2023

scrape button added #88

Are you sure you want to change the base?

scrape button added #88

Conversation

hkaur008 commented Oct 13, 2021 • edited Loading

Checklist

hkaur008 commented Oct 14, 2021

ideepika Oct 14, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ljflores Oct 26, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hkaur008 commented Oct 14, 2021 via email

kshtsk commented Oct 14, 2021

ideepika commented Oct 19, 2021

ljflores commented Oct 26, 2021 • edited Loading

hkaur008 commented Oct 26, 2021 via email

hkaur008 commented Dec 23, 2021 • edited Loading

hkaur008 commented Dec 23, 2021

hkaur008 commented Dec 23, 2021

ljflores commented Jan 3, 2022

hkaur008 commented Jan 4, 2022 via email

kamoltat left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hkaur008 commented Oct 13, 2021 •

edited

Loading

ideepika Oct 14, 2021 •

edited

Loading

ljflores Oct 26, 2021 •

edited

Loading

ljflores commented Oct 26, 2021 •

edited

Loading

hkaur008 commented Dec 23, 2021 •

edited

Loading

kamoltat left a comment •

edited

Loading