Update VeeR-EL2 codebase #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcockrell-google @howardtr @bharatpillilli Please take a look. |
mkurc-ant
force-pushed
the
mkurc/update-veer
branch
from
fe5bd87
to
786d57c
Compare
howardtr
reviewed
May 26, 2023
There was a problem hiding this comment.
would it be possible to also get the changes from this as well?
There was a problem hiding this comment.
Definitely, I included those changes.
Signed-off-by: Maciej Kurc <[email protected]>
mkurc-ant
force-pushed
the
mkurc/update-veer
branch
from
786d57c
to
55ad1fd
Compare
howardtr
approved these changes
May 30, 2023
| @@ -856,7 +857,7 @@ import el2_pkg::*; | |||
|
|
|||
| // ----------------- DEBUG END ----------------------------- | |||
|
|
|||
| assign core_rst_l = rst_l & (dbg_core_rst_l | scan_mode); | |||
| assign core_rst_l = rst_l & (scan_rst_l | scan_mode); | |||
There was a problem hiding this comment.
Just now noticing this.... shouldn't we be using ~scan_mode since this is an active-low reset? As-is, once we enter scan_mode, scan_rst_l has no effect on core_rst_l.
There was a problem hiding this comment.
you are right @calebofearth - @Nitsirks to also confirm this. We should file a bug and fix this - and understand what test/coverage shld have covered this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates VeeR-EL2 codebase by bringing in the following changes:
rvdffppe(rvdffppe elab issue Cores-VeeR-EL2#73, Correction of default WIDTH param value of rvdffppe Cores-VeeR-EL2#76)