rom: Implement fake fips verification using const generics #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurHeymans
force-pushed
the
improve_fake_rom
branch
from
ce8db1c
to
c0c244e
Compare
The fake rom codepath is largely similar to the regular codepath except certain parts get skipped. Instead of reimplementing most of the verification trait functions use a generic parameter in common code to determine whether the fake rom codepath needs to be taken. Use the "const-gen" crate to generate a constant literal that is used as the const generics input (using cfg!() won't work). Signed-off-by: Arthur Heymans <[email protected]>
Instead of having if else statement in the code handle this at the module level with 'use'. Signed-off-by: Arthur Heymans <[email protected]>
This reduces indentation making the code easier to read. Signed-off-by: Arthur Heymans <[email protected]>
Signed-off-by: Arthur Heymans <[email protected]>
ArthurHeymans
force-pushed
the
improve_fake_rom
branch
from
c0c244e
to
afcaf03
Compare
|
Closing this for now. We'll revisit this with additional design thinking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fake rom codepath is largely similar to the regular codepath except certain parts get skipped. Instead of reimplementing most of the verification trait functions use a generic parameter in common code to determine whether the fake rom codepath needs to be taken.
Use the "const-gen" crate to generate a constant literal that is used as the const generics input (using cfg!() won't work).