Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Image generator and verifier updates for Caliptra 2.0 FW ECC + LMS image #1694

Open
wants to merge 5 commits into
base: main-2.x
Choose a base branch
from
Open

[feat] Image generator and verifier updates for Caliptra 2.0 FW ECC + LMS image #1694

wants to merge 5 commits into from

Conversation

mhatrevi
Copy link
Collaborator

@mhatrevi mhatrevi commented Oct 1, 2024

No description provided.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 1, 2024 •
edited
Loading

CLA Not Signed

@mhatrevi mhatrevi added the Caliptra v2.0 Items to be considered for v2.0 Release label Oct 1, 2024
@mhatrevi mhatrevi changed the title [feat] Image generator update for generating Caliptra 2.0 FW ECC + LMA image [feat] Image generator update for generating Caliptra 2.0 FW ECC + LMS image Oct 1, 2024
swenson
swenson reviewed Oct 1, 2024
View reviewed changes
image/app/src/create/config.rs Outdated Show resolved Hide resolved
image/serde/src/lib.rs Outdated Show resolved Hide resolved
image/serde/src/lib.rs Outdated Show resolved Hide resolved
@mhatrevi mhatrevi marked this pull request as ready for review October 15, 2024 13:21
@mhatrevi mhatrevi changed the title [feat] Image generator update for generating Caliptra 2.0 FW ECC + LMS image [feat] Image generator and verifier updates for Caliptra 2.0 FW ECC + LMS image Oct 15, 2024
swenson
swenson approved these changes Oct 16, 2024
View reviewed changes
Copy link

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but curious about those two TODOs

rom/dev/tests/rom_integration_tests/test_update_reset.rs
@@ -516,7 +516,9 @@ fn test_fmc_is_16k() {
assert!(errs.is_empty());
}

#[test]
//#[test]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be disabled still?

image/verify/src/verifier.rs
@@ -345,6 +415,8 @@ impl<Env: ImageVerificationEnv> ImageVerifier<Env> {
caliptra_cfi_lib::cfi_assert_eq_12_words(&expected, &actual);
}

// [TODO] Verify active public key's digest from the descriptor hash list.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need to be done in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swenson swenson swenson approved these changes

@ArthurHeymans ArthurHeymans ArthurHeymans approved these changes

@jhand2 jhand2 Awaiting requested review from jhand2 jhand2 is a code owner

@fdamato fdamato Awaiting requested review from fdamato fdamato is a code owner

@rusty1968 rusty1968 Awaiting requested review from rusty1968 rusty1968 is a code owner

@bluegate010 bluegate010 Awaiting requested review from bluegate010 bluegate010 is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

@korran korran Awaiting requested review from korran korran is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

Assignees
No one assigned
Labels
Caliptra v2.0 Items to be considered for v2.0 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhatrevi @swenson @ArthurHeymans