Removes swagger-ui Fastify plugin, hopefully temporarily #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen reports like #550 where swagger-ui prevents the server from starting, permanently. I haven't been able to reproduce this yet. We've opened an issue on the plugin repo to see if they have ideas: fastify/fastify-swagger-ui#156 For now, we're not really in need of this anyway, so just remove it. I've also updated a bunch of deps and shimmed in the "DOM" types in our tsconfig since there are lots of errors when compiling during the lib check phase for things like esbuild, vitest.
Closed
chrisbenincasa
added a commit
that referenced
this pull request
Jun 22, 2024
We've seen reports like #550 where swagger-ui prevents the server from starting, permanently. I haven't been able to reproduce this yet. We've opened an issue on the plugin repo to see if they have ideas: fastify/fastify-swagger-ui#156 For now, we're not really in need of this anyway, so just remove it. I've also updated a bunch of deps and shimmed in the "DOM" types in our tsconfig since there are lots of errors when compiling during the lib check phase for things like esbuild, vitest.
markdavella
pushed a commit
to markdavella/tunarr
that referenced
this pull request
Jun 24, 2024
…asa#551) We've seen reports like chrisbenincasa#550 where swagger-ui prevents the server from starting, permanently. I haven't been able to reproduce this yet. We've opened an issue on the plugin repo to see if they have ideas: fastify/fastify-swagger-ui#156 For now, we're not really in need of this anyway, so just remove it. I've also updated a bunch of deps and shimmed in the "DOM" types in our tsconfig since there are lots of errors when compiling during the lib check phase for things like esbuild, vitest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen reports like
#550 where swagger-ui
prevents the server from starting, permanently. I haven't been able to
reproduce this yet. We've opened an issue on the plugin repo to see if
they have ideas:
fastify/fastify-swagger-ui#156
For now, we're not really in need of this anyway, so just remove it.
I've also updated a bunch of deps and shimmed in the "DOM" types in our
tsconfig since there are lots of errors when compiling during the lib
check phase for things like esbuild, vitest.