Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring unsupported commands when loading opcodes database. #128

Merged
merged 1 commit into from
Apr 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions source/OpcodeInfoDatabase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,16 @@ bool OpcodeInfoDatabase::_Load(const std::string filepath)
continue; // invalid command
}

auto attributes = c["attrs"];
if (attributes.JSONType() == JSON::Class::Object)
{
auto unsupported = attributes["is_unsupported"];
if (unsupported.JSONType() == JSON::Class::Boolean && unsupported.ToBool())
{
continue; // command defined as unsupported
}
}

auto idLong = stoul(commandId.ToString(), nullptr, 16);
if (idLong > 0x7FFF)
{
Expand Down
Loading