Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make audio streams handle work as in cleo4 #230

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

MiranDMC
Copy link
Collaborator

@MiranDMC MiranDMC commented Oct 7, 2024

Due to adding virtual functions to the audio stream class VMT pointer was added to the data layout. This caused stream handle (address) no longer pointing on property containing underlying BASS stream pointer.
Updated so more advanced scripts still can work with BASS as in CLEO4.

Unit tests working, audio demo script works too.

@MiranDMC MiranDMC requested a review from x87 October 7, 2024 17:15
@MiranDMC MiranDMC force-pushed the Make_audio_streams_handle_work_as_in_CLEO4 branch from 5819d7f to 7b4bf18 Compare October 10, 2024 21:40
@MiranDMC MiranDMC requested a review from x87 October 10, 2024 21:43
@MiranDMC MiranDMC force-pushed the Make_audio_streams_handle_work_as_in_CLEO4 branch from 7b4bf18 to 1462346 Compare October 10, 2024 21:50
@MiranDMC MiranDMC force-pushed the Make_audio_streams_handle_work_as_in_CLEO4 branch from 1462346 to 9fe0226 Compare October 10, 2024 22:05
source/CleoBase.cpp Outdated Show resolved Hide resolved
@MiranDMC MiranDMC force-pushed the Make_audio_streams_handle_work_as_in_CLEO4 branch 2 times, most recently from f015afb to b506e2c Compare October 12, 2024 10:38
source/CleoBase.cpp Outdated Show resolved Hide resolved
@MiranDMC MiranDMC force-pushed the Make_audio_streams_handle_work_as_in_CLEO4 branch from b506e2c to 814ae41 Compare October 12, 2024 19:50
@MiranDMC MiranDMC requested a review from x87 October 12, 2024 19:50
cleo_plugins/Audio/C3DAudioStream.cpp Outdated Show resolved Hide resolved
cleo_plugins/Audio/CAudioStream.cpp Outdated Show resolved Hide resolved
@MiranDMC MiranDMC force-pushed the Make_audio_streams_handle_work_as_in_CLEO4 branch from 6d9d67f to 661e8f8 Compare October 12, 2024 22:00
@x87 x87 merged commit de687b2 into master Oct 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants