-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drtprod: introduce target dependency #131942
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
4684a12
to
34843a3
Compare
e484d03
to
c5816ba
Compare
d626b38
to
8dd52ad
Compare
27fdecf
to
9609266
Compare
moving to draft to wait for other changes of tpcc and tpch to get merged. |
9609266
to
20f3caf
Compare
1116480
to
b579689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nameisbhaskar for the PR!
I have 2 nit comments. Apart from it, LGTM !
6aae7d4
to
2c50fda
Compare
ee550f9
to
1ffe6cf
Compare
Thanks @vidit-bhat and @sambhav-jain-16 for reviewing the PR. I have addressed the comments. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Thanks @nameisbhaskar for the changes !
1ffe6cf
to
70b5049
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
70b5049
to
849b7cf
Compare
Today there is no way to define dependency on other targets. This is needed in certain cases. e.g. if we want to copy certificates after both the clusters are ready. This PR also resolves an issue with roachprod command where the stdin input was not considered. Now, the command is executed with the interactive mode. Some more changes done for 150 node: schema_change is created without cron entry as we need manual control on it Epic: None Release note: None
849b7cf
to
f3be69f
Compare
Thanks @vidit-bhat and @sambhav-jain-16 for approving the changes! |
bors r=@sambhav-jain-16,@vidit-bhat |
131942: drtprod: introduce target dependency r=sambhav-jain-16,vidit-bhat a=nameisbhaskar Today there is no way to define dependency on other targets. This is needed in certain cases. e.g. if we want to copy certificates after both the clusters are ready. This PR also resolves an issue with roachprod command where the stdin input was not considered. Now, the command is executed with the interactive mode. Some more changes done for 150 node: schema_change is created without cron entry as we need manual control on it Epic: None Release note: None Co-authored-by: Bhaskarjyoti Bora <[email protected]>
Today there is no way to define dependency on other targets. This is needed in certain cases. e.g. if we want to copy certificates after both the clusters are ready.
This PR also resolves an issue with roachprod command where the stdin input was not considered. Now, the command is executed with the interactive mode.
Some more changes done for 150 node:
schema_change is created without cron entry as we need manual control on it
Epic: None
Release note: None