drtprod: introduce target dependency #131942
Merged
+269
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
nameisbhaskar
force-pushed
the
add-target-dependency
branch
2 times, most recently
from
4684a12
to
34843a3
Compare
nameisbhaskar
requested review from
DarrylWong and
vidit-bhat
and removed request for
a team
nameisbhaskar
force-pushed
the
add-target-dependency
branch
4 times, most recently
from
e484d03
to
c5816ba
Compare
nameisbhaskar
force-pushed
the
add-target-dependency
branch
6 times, most recently
from
d626b38
to
8dd52ad
Compare
nameisbhaskar
force-pushed
the
add-target-dependency
branch
4 times, most recently
from
27fdecf
to
9609266
Compare
|
moving to draft to wait for other changes of tpcc and tpch to get merged. |
nameisbhaskar
force-pushed
the
add-target-dependency
branch
from
9609266
to
20f3caf
Compare
nameisbhaskar
force-pushed
the
add-target-dependency
branch
3 times, most recently
from
1116480
to
b579689
Compare
vidit-bhat
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Thanks @nameisbhaskar for the PR!
I have 2 nit comments. Apart from it, LGTM !
nameisbhaskar
force-pushed
the
add-target-dependency
branch
2 times, most recently
from
6aae7d4
to
2c50fda
Compare
vidit-bhat
reviewed
Oct 25, 2024
nameisbhaskar
force-pushed
the
add-target-dependency
branch
2 times, most recently
from
ee550f9
to
1ffe6cf
Compare
|
Thanks @vidit-bhat and @sambhav-jain-16 for reviewing the PR. I have addressed the comments. PTAL |
sambhav-jain-16
approved these changes
Oct 25, 2024
vidit-bhat
reviewed
Oct 25, 2024
nameisbhaskar
force-pushed
the
add-target-dependency
branch
from
1ffe6cf
to
70b5049
Compare
nameisbhaskar
force-pushed
the
add-target-dependency
branch
from
70b5049
to
849b7cf
Compare
Today there is no way to define dependency on other targets. This is needed in certain cases. e.g. if we want to copy certificates after both the clusters are ready. This PR also resolves an issue with roachprod command where the stdin input was not considered. Now, the command is executed with the interactive mode. Some more changes done for 150 node: schema_change is created without cron entry as we need manual control on it Epic: None Release note: None
nameisbhaskar
force-pushed
the
add-target-dependency
branch
from
849b7cf
to
f3be69f
Compare
|
Thanks @vidit-bhat and @sambhav-jain-16 for approving the changes! |
|
bors r=@sambhav-jain-16,@vidit-bhat |
msbutler
pushed a commit
to msbutler/cockroach
that referenced
this pull request
Oct 25, 2024
131942: drtprod: introduce target dependency r=sambhav-jain-16,vidit-bhat a=nameisbhaskar Today there is no way to define dependency on other targets. This is needed in certain cases. e.g. if we want to copy certificates after both the clusters are ready. This PR also resolves an issue with roachprod command where the stdin input was not considered. Now, the command is executed with the interactive mode. Some more changes done for 150 node: schema_change is created without cron entry as we need manual control on it Epic: None Release note: None Co-authored-by: Bhaskarjyoti Bora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today there is no way to define dependency on other targets. This is needed in certain cases. e.g. if we want to copy certificates after both the clusters are ready.
This PR also resolves an issue with roachprod command where the stdin input was not considered. Now, the command is executed with the interactive mode.
Some more changes done for 150 node:
schema_change is created without cron entry as we need manual control on it
Epic: None
Release note: None