Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple AEB #33535

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Simple AEB #33535

wants to merge 3 commits into from

Conversation

adeebshihadeh
Copy link
Contributor

@adeebshihadeh adeebshihadeh commented Sep 10, 2024

  • trigger with left blinker
  • abstractions
  • Toyota first?
  • gate behind a debug param

open questions

  • CC.longActive = True for AEB?

@sshane
Copy link
Contributor

sshane commented Sep 11, 2024

longActive being true sounds confusing, you don't want to accidentally leave it on and transition into normal ACC. Maybe we need a longState (=off, on, aeb), or is that more confusing?

@jyoung8607
Copy link
Collaborator

 CC.longActive = True for AEB?

Probably not. At least some different active state. For AEB you need to a) go active spontaneously when the user hasn't explicitly engaged, and b) continue actuating with driver braking (preexisting or rising edge) or even opposing driver gas (probably preexisting only). These are all completely antithetical to the existing safety model and would make conventional ACC safety hopelessly untestable spaghetti.

@adeebshihadeh adeebshihadeh force-pushed the simple-toyota-aeb branch 2 times, most recently from f9a46d5 to 5eb9f1f Compare September 12, 2024 00:46
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Sep 22, 2024
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

Copy link
Contributor

github-actions bot commented Oct 5, 2024

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Oct 5, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants