-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 8.8.0.121 and add CUDA 12 support. #56
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2023.04.24.17.32.25
…thy 3.23.1, and conda-forge-pinning 2023.04.24.17.32.25
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/cudnn-feedstock/actions/runs/4791287396. |
…nda-forge-pinning 2023.04.24.19.44.12
cc: @jakirkham @leofang @adibbley @robertmaynard for notice/review. I think CI should pass this round (still running). |
(and thanks in advance to @kkraus14 as package maintainer for a review, as well) 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Bradley! LGTM except for one nit.
Q: Would it possible that we try moving ppc64le back to Travis? It is slightly stabler than before, so if it can complete aarch64 in less than 15 mins, it might work for ppc64le too. Not a blocking change, though, and I am no longer the maintainer here 🙂 |
Co-authored-by: Leo Fang <[email protected]>
I also, would like to no longer be a recipe maintainer for this package. Is there any chance someone else would like to be added? cc @adibbley |
We were going to propose adding some folks here. Would suggest: |
@conda-forge-admin, please re-render |
…nda-forge-pinning 2023.04.25.18.40.51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one question about the dev package but otherwise lgtm. Thanks for taking over the maintenance of this package.
Thanks all! 🙏 Keith, could you please give this another look when you have a chance? |
Ideally this |
I think that is a good long-term plan. I'm hesitant to introduce that change right now, but the impact of that change can be surveyed and we can move in that direction over time. I'll file an issue. edit: #57 |
Should add this same discussion came up offline previously and we decided to punt for now |
Thanks all! 🙏 Going ahead and merging to get these packages out. Let's follow up on anything else separately 🙂 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)This PR updates cuDNN to 8.8.0.121 with support for CUDA 11 and CUDA 12.
Fixes #54