Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 8.8.0.121 and add CUDA 12 support. #56

Merged
merged 15 commits into from
Apr 26, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 24, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR updates cuDNN to 8.8.0.121 with support for CUDA 11 and CUDA 12.

Fixes #54

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bdice
Copy link
Contributor Author

bdice commented Apr 24, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cudnn-feedstock/actions/runs/4791287396.

@bdice bdice marked this pull request as ready for review April 25, 2023 00:06
@bdice bdice requested a review from kkraus14 as a code owner April 25, 2023 00:06
@bdice
Copy link
Contributor Author

bdice commented Apr 25, 2023

cc: @jakirkham @leofang @adibbley @robertmaynard for notice/review. I think CI should pass this round (still running).

@bdice
Copy link
Contributor Author

bdice commented Apr 25, 2023

(and thanks in advance to @kkraus14 as package maintainer for a review, as well) 🙏

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Bradley! LGTM except for one nit.

recipe/meta.yaml Outdated Show resolved Hide resolved
@leofang
Copy link
Member

leofang commented Apr 25, 2023

Q: Would it possible that we try moving ppc64le back to Travis? It is slightly stabler than before, so if it can complete aarch64 in less than 15 mins, it might work for ppc64le too. Not a blocking change, though, and I am no longer the maintainer here 🙂

recipe/meta.yaml Outdated Show resolved Hide resolved
@kkraus14
Copy link

I also, would like to no longer be a recipe maintainer for this package. Is there any chance someone else would like to be added? cc @adibbley

@jakirkham
Copy link
Member

We were going to propose adding some folks here. Would suggest:

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

Copy link

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question about the dev package but otherwise lgtm. Thanks for taking over the maintenance of this package.

@jakirkham
Copy link
Member

Thanks all! 🙏

Keith, could you please give this another look when you have a chance?

@kkraus14
Copy link

Ideally this cudnn package should probably be split into a runtime and dev package, where the dev package then makes sense to depend on cudart-dev

@bdice
Copy link
Contributor Author

bdice commented Apr 26, 2023

Ideally this cudnn package should probably be split into a runtime and dev package, where the dev package then makes sense to depend on cudart-dev

I think that is a good long-term plan. I'm hesitant to introduce that change right now, but the impact of that change can be surveyed and we can move in that direction over time. I'll file an issue.

edit: #57

@jakirkham
Copy link
Member

Should add this same discussion came up offline previously and we decided to punt for now

@jakirkham jakirkham merged commit acb3291 into conda-forge:main Apr 26, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Going ahead and merging to get these packages out. Let's follow up on anything else separately 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cuDNN: Support CUDA 12
4 participants