[v4] Fix compatibility with nette/forms 3.2.3 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jtojnar Hi, can you make PR green? Thanks. |
|
It is planned but I have not gotten around to it yet. The PHPStan issue can be easily fixed by a cast – I verified that But I still need to debug the other test failure. I suspect it is caused by some BC break in Latte: |
nette/forms@e227d87 added an extra argument. While at it, let’s also narrow the `$values` argument type to match `Container::setValues`. This change remains compatible with nette/forms 3.2.2. (cherry picked from commits 1d9a356, 73f42f5)
|
I have bisected the Latte failure to nette/application@1aba9da and resolved it in WebChemistry/testing-helpers#13. |
nette/forms@0cd5069 added more types but that is overly broad for our usage pattern. We need to cast it to proper value until the return type is clarified upstream. (cherry picked from commits 45cf2a8, bfe52eb)
`make coverage` would fail with:
No code coverage driver available
Sounds like it might have been broken by xdebug 2 → 3 bump:
https://xdebug.org/docs/upgrade_guide#New-Concepts
Cargo culted from contributte/invoice@ca51236
(cherry picked from commit bfe52eb)
|
@jtojnar Nice job, mate! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nette/forms@e227d87 added an extra argument.
While at it, let’s also narrow the
$valuesargument type to matchContainer::setValues.This change remains compatible with nette/forms 3.2.2.
Backports #107