Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] Fix compatibility with nette/forms 3.2.3 #108

Merged
merged 3 commits into from
May 14, 2024
Merged

[v4] Fix compatibility with nette/forms 3.2.3 #108

merged 3 commits into from
May 14, 2024

Commits on May 14, 2024

  1. Fix compatibility with nette/forms 3.2.3 

    nette/forms@e227d87 added an extra argument.

While at it, let’s also narrow the `$values` argument type to match `Container::setValues`.

This change remains compatible with nette/forms 3.2.2.

(cherry picked from commits 1d9a356, 73f42f5)
    @jtojnar
    jtojnar committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f86aca5 View commit details
    Browse the repository at this point in the history

  2. Fix PHPStan issue after nette/forms added more types 

    nette/forms@0cd5069 added more types but that is overly broad for our usage pattern. We need to cast it to proper value until the return type is clarified upstream.

(cherry picked from commits 45cf2a8, bfe52eb)
    @jtojnar
    jtojnar committed May 14, 2024
    Configuration menu
    Copy the full SHA
    715d759 View commit details
    Browse the repository at this point in the history

  3. makefile: Fix code coverage 

    `make coverage` would fail with:

    No code coverage driver available

Sounds like it might have been broken by xdebug 2 → 3 bump:
https://xdebug.org/docs/upgrade_guide#New-Concepts

Cargo culted from contributte/invoice@ca51236

(cherry picked from commit bfe52eb)
    @jtojnar
    jtojnar committed May 14, 2024
    Configuration menu
    Copy the full SHA
    289316f View commit details
    Browse the repository at this point in the history