Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(systemtests): update systemtests docs #23061

Closed
wants to merge 2 commits into from
+6 −6
Closed

docs(systemtests): update systemtests docs #23061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
133bb85
docs: fix spelling errors in the description
ChengenH Dec 16, 2024
dba92a3
docs(systemtests): update systemtests docs
ChengenH Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion baseapp/abci.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ func (app *BaseApp) PrepareProposal(req *abci.PrepareProposalRequest) (resp *abc

// Abort any running OE so it cannot overlap with `PrepareProposal`. This could happen if optimistic
// `internalFinalizeBlock` from previous round takes a long time, but consensus has moved on to next round.
// Overlap is undesirable, since `internalFinalizeBlock` and `PrepareProoposal` could share access to
// Overlap is undesirable, since `internalFinalizeBlock` and `PrepareProposal` could share access to
// in-memory structs depending on application implementation.
// No-op if OE is not enabled.
// Similar call to Abort() is done in `ProcessProposal`.
Expand Down
2 changes: 1 addition & 1 deletion codec/collections.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ func protoCol(f protoreflect.FieldDescriptor) schema.Field {
case protoreflect.EnumKind:
// TODO: support enums
col.Kind = schema.EnumKind
// use the full name to avoid collissions
// use the full name to avoid collisions
col.ReferencedType = string(f.Enum().FullName())
col.ReferencedType = strings.ReplaceAll(col.ReferencedType, ".", "_")
case protoreflect.MessageKind:
Expand Down
2 changes: 1 addition & 1 deletion server/v2/cometbft/abci.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ func (c *consensus[T]) PrepareProposal(

// Abort any running OE so it cannot overlap with `PrepareProposal`. This could happen if optimistic
// `internalFinalizeBlock` from previous round takes a long time, but consensus has moved on to next round.
// Overlap is undesirable, since `internalFinalizeBlock` and `PrepareProoposal` could share access to
// Overlap is undesirable, since `internalFinalizeBlock` and `PrepareProposal` could share access to
// in-memory structs depending on application implementation.
// No-op if OE is not enabled.
// Similar call to Abort() is done in `ProcessProposal`.
Expand Down
6 changes: 3 additions & 3 deletions systemtests/system.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ func (s *SystemUnderTest) ModifyGenesisJSON(t *testing.T, mutators ...GenesisMut
s.modifyGenesisJSON(t, mutators...)
}

// modify json without enforcing a reset
// modifyGenesisJSON modify json without enforcing a reset
func (s *SystemUnderTest) modifyGenesisJSON(t *testing.T, mutators ...GenesisMutator) {
t.Helper()
require.Empty(t, s.currentHeight.Load(), "forced chain reset required")
Expand Down Expand Up @@ -606,7 +606,7 @@ func (s *SystemUnderTest) startNodesAsync(t *testing.T, xargs ...string) {
})
}

// tracks the PID in state with a go routine waiting for the shutdown completion to unregister
// awaitProcessCleanup tracks the PID in state with a go routine waiting for the shutdown completion to unregister
func (s *SystemUnderTest) awaitProcessCleanup(cmd *exec.Cmd) {
pid := cmd.Process.Pid
s.pidsLock.Lock()
Expand Down Expand Up @@ -777,7 +777,7 @@ func (s *SystemUnderTest) NewEventListener(t *testing.T) *EventListener {
return NewEventListener(t, s.rpcAddr)
}

// is any process let running?
// anyNodeRunning is any process let running?
func (s *SystemUnderTest) anyNodeRunning() bool {
s.pidsLock.RLock()
defer s.pidsLock.RUnlock()
Expand Down
Loading