Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds initial draft for iterators topic #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

vulder
Copy link
Collaborator

@vulder vulder commented May 12, 2024

Co-authored-by: JC van Winkel [email protected]
Co-authored-by: Bogusław Cyganek [email protected]
Co-authored-by: Jari Ronkainen [email protected]

Co-authored-by: JC van Winkel <[email protected]>
Co-authored-by: Bogusław Cyganek <[email protected]>
Co-authored-by: Jari Ronkainen <[email protected]>
@vulder vulder added the Tentatively ready Ready for a final review in SG20 label May 12, 2024
@vulder vulder requested a review from jcvw May 12, 2024 11:23

Main Writing iterators

Advanced ---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "endowing iterators with execution policies" under advanced?

Copy link

@ronchaine ronchaine May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not mind at all this being added, but I would change the wording because I doubt "endow" is a common enough verb for every non-native speaker. I do not have a better replacement on the top of my head, maybe extend, since it's more used in programming circles? It could be a bit too overloaded though and the sentence would become a bit clunky.

* Difference between value/reference semantics based for loops
* Explain connection to for-each
* Basic iterator nomenclature and functionality
* begin/end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain that begin/end are methods for the container class, but advance/dereference are methods for the iterator class, which is a ?subclass? of the container class.

Copy link
Collaborator

@jcvw jcvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tentatively ready Ready for a final review in SG20
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants