Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the navbar to meet the design system requirement #830

Conversation

Dev-JoyA
Copy link
Contributor

@Dev-JoyA Dev-JoyA commented Oct 13, 2024

Fixes

Description

This PR updates the navbar to align with the design system and corrects the mobile menu. Specifically, it replaces the hamburger icon with a "Menu" button on smaller screens to ensure consistency with the design system.

Technical details

creativecommons/vocabulary: A cohesive system of design for Creative Commons

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Dev-JoyA Dev-JoyA requested review from a team as code owners October 13, 2024 16:34
@Dev-JoyA Dev-JoyA requested review from TimidRobot, possumbilities and Cronus1007 and removed request for a team October 13, 2024 16:34
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to use Vocabulary, added in:

themes/vocabulary_theme/templates/layout.html Outdated Show resolved Hide resolved
@TimidRobot TimidRobot self-assigned this Oct 24, 2024
@TimidRobot TimidRobot added the 🚧 status: blocked Blocked & therefore, not ready for work label Oct 24, 2024
@TimidRobot

This comment was marked as outdated.

@TimidRobot TimidRobot changed the base branch from main to vocab-refresh November 5, 2024 15:10
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work!!

(target branch changed to vocab-refresh as the various page parts are interdependent)

@TimidRobot TimidRobot merged commit ccc1547 into creativecommons:vocab-refresh Nov 5, 2024
1 check passed
@TimidRobot TimidRobot removed the 🚧 status: blocked Blocked & therefore, not ready for work label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature] Mobile Menu does not match the current Vocabulary design system
2 participants