Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align the navbar to meet the design system requirement #830

Merged
merged 9 commits into from
Nov 5, 2024
Merged

Align the navbar to meet the design system requirement #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
47fc58d
Align the navbar to meet the design system requirement
Dev-JoyA Oct 13, 2024
4d6b22e
Added necessary changes for mobile menu
Dev-JoyA Oct 13, 2024
7a87c58
Aded changes from main
Dev-JoyA Oct 17, 2024
f2bba16
Merge branch 'main' into feature/enhance-mobile-menu-to0match-design-…
TimidRobot Oct 21, 2024
48f3500
Align the navbar to meet the design system requirement
Dev-JoyA Oct 13, 2024
a973b8f
Added necessary changes for mobile menu
Dev-JoyA Oct 13, 2024
16e0ee9
resolved conflict
Dev-JoyA Oct 22, 2024
74721f8
resolved issue that might cause page break in vocabulary.css
Dev-JoyA Oct 22, 2024
c1f16b7
Merge branch 'main' into feature/enhance-mobile-menu-to0match-design-…
TimidRobot Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/static/vocabulary/css/vocabulary.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ EX:
/* typography */

body {
display: grid;
/* display: grid;
grid-template-columns: 5% 3% 6% 6% 15% 30% 15% 6% 6% 3% 5%;
overflow-x: hidden;
overflow-x: hidden; */

font-weight: 400;
-moz-osx-font-smoothing: grayscale;
Expand Down
5 changes: 3 additions & 2 deletions themes/vocabulary_theme/templates/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@
</svg>
</a>
<a role="button" class="navbar-burger" aria-label="menu" aria-expanded="false">
<!-- <span aria-hidden="true"></span>
<span aria-hidden="true"></span>
<span aria-hidden="true"></span>
<span aria-hidden="true"></span>
<span aria-hidden="true"></span> -->
Menu
</a>
</div>
<div class="navbar-menu">
Expand Down
32 changes: 32 additions & 0 deletions webpack/sass/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,3 +160,35 @@ pre {
left: auto;
}
}

@media screen and (max-width: 780px){
.navbar-item, .navbar-item a{
border-top: 1px solid rgba(212, 210, 210, 0.945);
padding-top: 1rem;
padding-bottom: 1rem;
}

.navbar-burger{
cursor: pointer;
display: block;
background-color: #ebeeee;
padding: 0.5rem 0.2rem 0rem ;
font-weight: 900;
font-size: 20px;
color: rgb(64, 60, 60);
margin: 5px auto;
// align-items: center;
box-shadow: 0 2px 5px rgba(0, 0, 0, 0.2);
transition: background-color 0.3s ease-in-out;
min-width: 100px;
text-align: center;
line-height: 1;
border-radius: 2%;;
}

.navbar-brand {
display: flex;
justify-content: space-between;
}
}