[CRT-5] Classes API - E2E tests #59
Conversation
| const checkClassesInList = (expectedClasses, returnedClasses): void => { | ||
| expect(returnedClasses).toHaveLength(expectedClasses.length); | ||
| returnedClasses.forEach((returnedClass) => { | ||
| const { teacherId, ...referenceClass } = expectedClasses.find( | ||
| (c) => c.id == returnedClass.id, | ||
| ); | ||
| expect(returnedClass).toMatchObject(referenceClass); | ||
|
|
||
| const { | ||
| type: _ignore_type, | ||
| email: _ignore_email, | ||
| ...referenceTeacher | ||
| } = users.find((u) => u.id === teacherId)!; | ||
| expect(returnedClass.teacher).toMatchObject(referenceTeacher); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
This can probably be done better, I would like to develop a library of matchers, but I believe it should be "good enough" for now :-)
| id: defaultTeacher.id, | ||
| name: defaultTeacher.name, | ||
| }, | ||
| sessions: [], |
There was a problem hiding this comment.
the seed data doesn't have sessions for now, otherwise this would have to be computed too.
| type: _ignore_type, | ||
| email: _ignore_email, |
There was a problem hiding this comment.
do we want to assert the absence of those fields instead? (also fine for me if we add a comment and do it later)
There was a problem hiding this comment.
they're there and I literally don't want them in the referenceTeacher :-)
There was a problem hiding this comment.
But longer term, I'd like to have proper matchers for the various DTOs.
| test("/classes (POST)", async () => { | ||
| const dto = { name: "New Class", teacherId: defaultTeacher.id }; | ||
|
|
||
| const response = await request(app.getHttpServer()) | ||
| .post("/classes") | ||
| .send(dto) | ||
| .expect(201); | ||
|
|
||
| expect(response.body).toEqual({ id: 1, ...dto }); | ||
| }); | ||
|
|
||
| test("/classes/:id (PATCH)", async () => { | ||
| const klass = classes[0]; | ||
| const dto = { name: "Updated Class", teacherId: defaultTeacher.id }; | ||
|
|
||
| const response = await request(app.getHttpServer()) | ||
| .patch(`/classes/${klass.id}`) | ||
| .send(dto) | ||
| .expect(200); | ||
|
|
||
| expect(response.body).toEqual({ id: klass.id, ...dto }); | ||
| }); | ||
|
|
||
| test("/classes/:id (DELETE)", async () => { | ||
| const klass = classes[0]; | ||
| const response = await request(app.getHttpServer()) | ||
| .delete(`/classes/${klass.id}`) | ||
| .expect(200); | ||
|
|
||
| expect(response.body).toEqual(klass); |
There was a problem hiding this comment.
While at it, why not add a "not found" test for POST, PATCH & DELETE as well? :)
There was a problem hiding this comment.
That would be helpful indeed ^^
No description provided.