Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logitech feature Illumination #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abergmeier
Copy link

This makes it more concrete on Litra Glow.
Also mention that we saw 0x1eb0 on Litra Glow.

This makes it more concrete on Litra Glow.
Also mention that we saw 0x1eb0 on Litra Glow.
@@ -69,8 +69,10 @@ static const std::map<uint16_t, const char *> HIDPP20Features = {
{ 0x1bc0, "Persistent remappable action" },
{ 0x1d4b, "Wireless device status" },
{ 0x1e00, "Enable hidden features" },
//{ 0x1eb0, "Seen on Logitech Litra Glow" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1EB0 is also used in a number of other devices, like a mouse from 2015, another mouse, etc.
Short of knowing what it is, I don't see a reason to add it to the list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an internal generic test/development feature that's not useful to users and won't be publicly documented. Devices do different things with that feature and it's not specific to the Litra Glow.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the documentation, that it IS a test feature a good reason to add it to the list - even only as a comment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that depends on the purpose of the list. It seems it mostly lists features that showed up in public documentation. But one could obviously shoot for completeness, in which case { 0x1eb0, "Internal test feature" } would be an entirely reasonable entry. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants